-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HPA Flags for horizontal-pod-autoscaler-initial-readiness-delay
& horizontal-pod-autoscaler-cpu-initialization-period
#10241
Conversation
Enable setting of the `horizontal-pod-autoscaler-initial-readiness-delay` and `horizontal-pod-autoscaler-cpu-initialization-period` flags
For `HorizontalPodAutoscalerInitialReadinessDelay` & `HorizontalPodAutoscalerCPUInitializationPeriod`
Welcome @JoelBCarter! |
Hi @JoelBCarter. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Was about to suggest to order the flags in alphabetical order but it looks like the entire file is not in alphabetical order. Shoud be fine but. /lgtm |
@bharath-123: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bharath-123 I started down that same path and came to the same conclusion. I kept it as is because I didn't want to add noise to the diff. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelBCarter, johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
…-upstream-release-1.19 Automated cherry pick of #10241: Expose flags for HorizontalPodAutoscaler
Flags described in Kubernetes docs here