Add Azure support #10114

kenji-cloudnatix · 2020-10-26T22:36:48Z

This commit contains all changes required to support Azure
(#3957).

As we discussed in the ticket, this helps understand the entire changes needed. Very unlikely to merge this PR as-is.

One thing I wasn't sure about was what's the best way to have Azure specific configuration in the cluster spec. For example, it makes sense to have Resource Group in a cluster spec so that users can build a k8s cluster in their existing Resource Group. On the other hand, adding Azure specific config to the clustrer spec doesn't look good. Currently I just defined AzureSpec inside the cluster spec.

k8s-ci-robot · 2020-10-26T22:36:55Z

Welcome @kenji-cloudnatix!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-10-26T22:36:56Z

Hi @kenji-cloudnatix. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2020-10-26T22:37:01Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rifelpet

I left a few minor comments just from a quick scan through but I'll give a closer look sometime soon. You'll also need to sign the CLA with your github email according to one of the above k8s-ci-robot comments. Once you do that we can enable CI testing, and feel free to open the VFS PR next.

upup/pkg/fi/cloudup/azure/status.go

docs/cli/kops_create_cluster.md

rifelpet · 2020-10-27T00:46:48Z

pkg/apis/kops/v1alpha2/cluster.go

+	// empty, kops will not create a new resource group, and
+	// it will just reuse the existing resource group of the name.
+	// This follows the model that kops takes for AWS VPC.
+	ResourceGroupName string `json:"resourceGroupName,omitempty"`


Optional API fields typically use pointers to more easily denote nil as being unset.

I don't agree that is a necessary pattern. Using a pointer is only necessary when it is useful to distinguish the default value from an explicitly specified zero value. In this case an exiting resource group named with the empty string would not be reasonable.

kenji-cloudnatix · 2020-10-27T06:23:23Z

Thanks for the review. Yes, let me talk internally to get CLA signed.

rifelpet · 2020-11-02T22:51:43Z

@kenji-cloudnatix any update on signing the CLA?

kenji-cloudnatix · 2020-11-02T22:53:23Z

Sorry for the delay, we've been talking internally, but no update yet. Will given an update in a few days..

hakman · 2020-11-14T07:44:48Z

Hey @kenji-cloudnatix, how are things going? Any news? 😄

kenji-cloudnatix · 2020-11-16T16:54:43Z

Sorry, no update yet.. :( I pinged the team again. Hopefully this will get resolved today or tomorrow..

kenji-cloudnatix · 2020-11-17T06:01:36Z

Sorry again for taking a long time, but I've signed CLA. Will rebase the PR tomorrow. Thanks!

hakman · 2020-11-17T06:16:58Z

That's great! Thanks @kenji-cloudnatix.

kenji-cloudnatix · 2020-12-11T17:51:09Z

Sure! Filed #10412 . Adding a "getting started doc".

rifelpet

Thanks for the docs update! A few minor things to make it more concise. Hopefully you understand the "```" issues I had with github suggestions. I'm hoping this will be the final review before we can merge.

docs/getting_started/azure.md

pkg/apis/kops/componentconfig.go

kenji-cloudnatix

Thanks for the quick and detailed review, @rifelpet !

docs/getting_started/azure.md

rifelpet

A few formatting issues to address, mostly around my inability to suggest the exact changes through GH's suggestions features :) and I forgot that you'll need to add the new page to the docs site menu too

docs/getting_started/azure.md

rifelpet · 2020-12-13T14:46:52Z

docs/getting_started/azure.md

+\```
+$ kops update cluster  \
+  --name my-azure.k8s.local
+\```
+
+Now add the `--yes` flag to have kOps provision the resources
+and create the cluster. This will also add a kubeconfig context
+for the cluster.
+
+\```
+$ kops update cluster  \
+  --name my-azure.k8s.local \
+  --yes
+\```


these code blocks arent working because of the \ in front of the triple backticks

kenji-cloudnatix

Thanks! Updated mkdocs.yml as well.

kenji-cloudnatix · 2020-12-14T16:33:25Z

docs/getting_started/azure.md

+\```
+$ kops update cluster  \
+  --name my-azure.k8s.local
+\```
+
+Now add the `--yes` flag to have kOps provision the resources
+and create the cluster. This will also add a kubeconfig context
+for the cluster.
+
+\```
+$ kops update cluster  \
+  --name my-azure.k8s.local \
+  --yes
+\```


docs/getting_started/azure.md

rifelpet · 2020-12-14T17:03:26Z

/retest
/lgtm

Any other approvers want to take a look at this? Otherwise I think it is ready to merge

hack/.packages

upup/pkg/fi/cloudup/azuretasks/vmscaleset.go

This commit contains all changes required to support Azure (kubernetes#3957).

hakman · 2020-12-21T16:51:24Z

Thanks @kenji-cloudnatix, time to merge :)
/lgtm
/approve

k8s-ci-robot · 2020-12-21T16:51:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, kenji-cloudnatix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [hakman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kenji-cloudnatix · 2020-12-21T17:16:30Z

Thanks for all the efforts for code review, @rifelpet @hakman !

chrislovecnm · 2020-12-21T18:46:22Z

@kenji-cloudnatix THANKS!!! This as been a long time coming!

rendhalver · 2021-03-25T03:41:28Z

Wowie! Thanks gang! <3

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 26, 2020

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 26, 2020

k8s-ci-robot requested review from gjtempleton and joshbranham October 26, 2020 22:37

k8s-ci-robot added area/addons area/api area/documentation area/kops-controller area/nodeup labels Oct 26, 2020

kenji-cloudnatix mentioned this pull request Oct 26, 2020

Azure Support #3957

Open

kenji-cloudnatix force-pushed the azure2 branch from d21625b to 544258a Compare October 26, 2020 23:50

rifelpet reviewed Oct 27, 2020

View reviewed changes

hakman requested review from justinsb, mikesplain and hakman and removed request for joshbranham and gjtempleton October 27, 2020 04:41

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2020

kenji-cloudnatix force-pushed the azure2 branch from 544258a to 8c06680 Compare November 18, 2020 00:32

kenji-cloudnatix force-pushed the azure2 branch from d8c9455 to 412f237 Compare December 11, 2020 18:40

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2020

rifelpet reviewed Dec 12, 2020

View reviewed changes

kenji-cloudnatix commented Dec 13, 2020

View reviewed changes

docs/getting_started/azure.md Outdated Show resolved Hide resolved

rifelpet reviewed Dec 13, 2020

View reviewed changes

kenji-cloudnatix commented Dec 14, 2020

View reviewed changes

kenji-cloudnatix force-pushed the azure2 branch from 8cc2951 to 87a27a6 Compare December 14, 2020 16:36

rifelpet reviewed Dec 14, 2020

View reviewed changes

docs/getting_started/azure.md Outdated Show resolved Hide resolved

k8s-ci-robot assigned rifelpet Dec 14, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2020

hakman reviewed Dec 21, 2020

View reviewed changes

hack/.packages Outdated Show resolved Hide resolved

kenji-cloudnatix force-pushed the azure2 branch from d9101ff to f57b0b2 Compare December 21, 2020 15:41

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2020

rifelpet reviewed Dec 21, 2020

View reviewed changes

upup/pkg/fi/cloudup/azuretasks/vmscaleset.go Outdated Show resolved Hide resolved

kenji-cloudnatix force-pushed the azure2 branch from f57b0b2 to 350f125 Compare December 21, 2020 16:20

Add Azure support

a61caea

This commit contains all changes required to support Azure (kubernetes#3957).

kenji-cloudnatix force-pushed the azure2 branch from 350f125 to a61caea Compare December 21, 2020 16:28

k8s-ci-robot assigned hakman Dec 21, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2020

k8s-ci-robot merged commit 4eaa97b into kubernetes:master Dec 21, 2020

k8s-ci-robot added this to the v1.20 milestone Dec 21, 2020

kenji-cloudnatix deleted the azure2 branch December 21, 2020 17:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Azure support #10114

Add Azure support #10114

kenji-cloudnatix commented Oct 26, 2020

k8s-ci-robot commented Oct 26, 2020

k8s-ci-robot commented Oct 26, 2020

k8s-ci-robot commented Oct 26, 2020

rifelpet left a comment

rifelpet Oct 27, 2020

johngmyers Oct 30, 2020

kenji-cloudnatix commented Oct 27, 2020

rifelpet commented Nov 2, 2020

kenji-cloudnatix commented Nov 2, 2020

hakman commented Nov 14, 2020

kenji-cloudnatix commented Nov 16, 2020

kenji-cloudnatix commented Nov 17, 2020

hakman commented Nov 17, 2020

kenji-cloudnatix commented Dec 11, 2020

rifelpet left a comment

kenji-cloudnatix left a comment

rifelpet left a comment

rifelpet Dec 13, 2020

kenji-cloudnatix Dec 14, 2020

kenji-cloudnatix left a comment

kenji-cloudnatix Dec 14, 2020

rifelpet commented Dec 14, 2020

hakman commented Dec 21, 2020

k8s-ci-robot commented Dec 21, 2020

kenji-cloudnatix commented Dec 21, 2020

chrislovecnm commented Dec 21, 2020

rendhalver commented Mar 25, 2021

Add Azure support #10114

Add Azure support #10114

Conversation

kenji-cloudnatix commented Oct 26, 2020

k8s-ci-robot commented Oct 26, 2020

k8s-ci-robot commented Oct 26, 2020

k8s-ci-robot commented Oct 26, 2020

rifelpet left a comment

Choose a reason for hiding this comment

rifelpet Oct 27, 2020

Choose a reason for hiding this comment

johngmyers Oct 30, 2020

Choose a reason for hiding this comment

kenji-cloudnatix commented Oct 27, 2020

rifelpet commented Nov 2, 2020

kenji-cloudnatix commented Nov 2, 2020

hakman commented Nov 14, 2020

kenji-cloudnatix commented Nov 16, 2020

kenji-cloudnatix commented Nov 17, 2020

hakman commented Nov 17, 2020

kenji-cloudnatix commented Dec 11, 2020

rifelpet left a comment

Choose a reason for hiding this comment

kenji-cloudnatix left a comment

Choose a reason for hiding this comment

rifelpet left a comment

Choose a reason for hiding this comment

rifelpet Dec 13, 2020

Choose a reason for hiding this comment

kenji-cloudnatix Dec 14, 2020

Choose a reason for hiding this comment

kenji-cloudnatix left a comment

Choose a reason for hiding this comment

kenji-cloudnatix Dec 14, 2020

Choose a reason for hiding this comment

rifelpet commented Dec 14, 2020

hakman commented Dec 21, 2020

k8s-ci-robot commented Dec 21, 2020

kenji-cloudnatix commented Dec 21, 2020

chrislovecnm commented Dec 21, 2020

rendhalver commented Mar 25, 2021