Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite ssh user to ubuntu in bastions docs #10044

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Rewrite ssh user to ubuntu in bastions docs #10044

merged 2 commits into from
Oct 15, 2020

Conversation

h3poteto
Copy link
Contributor

@h3poteto h3poteto commented Oct 12, 2020 •
edited
Loading

Refs: #9751
I only update a doc kops-tests-private-net-bastion-host.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 12, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @h3poteto. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 12, 2020
@hakman
Copy link
Member

hakman commented Oct 13, 2020

@h3poteto Hello again. In this case, I think we may want to update all docs from admin@ to ubuntu@. There maybe be some other references to Debian in those places that should be updated also.
Would this be ok for you?

@h3poteto
Copy link
Contributor Author

Hi, OK, I see.
I will update all user from admin@ to ubuntu@.

@hakman
Copy link
Member

hakman commented Oct 13, 2020

Thanks @h3poteto

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 14, 2020
@h3poteto h3poteto changed the title Add notes for ubuntu users to documents when using bastion Rewrite ssh user to ubuntu in bastions docs Oct 14, 2020
@h3poteto
Copy link
Contributor Author

h3poteto commented Oct 14, 2020 •
edited
Loading

@hakman I updated kops-tests-private-net-bastion-host.
Should I rewrite ssh user in other documents as well?
I found admin user for ssh in some documents, but I haven't confirmed if they are the correct information yet.

@johngmyers
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 15, 2020
hakman
hakman requested changes Oct 15, 2020
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this commit focused on this file.The rest of the admin@ can be updated in a followup PR.

docs/examples/kops-tests-private-net-bastion-host.md
@@ -148,8 +148,8 @@ kind: InstanceGroup
metadata:
name: bastions
spec:
image: kope.io/k8s-1.7-debian-jessie-amd64-hvm-ebs-2017-07-28
machineType: t2.micro
image: 099720109477/ubuntu/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-20200907
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another reference to a kope.io image in the file. Please update that one too.
Also, please change t2.micro to t3.micro everywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it in aff8c0a

@h3poteto h3poteto force-pushed the iss-9751 branch 2 times, most recently from a7f8b6d to 3b6b019 Compare October 15, 2020 13:07
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 15, 2020
@hakman
Copy link
Member

hakman commented Oct 15, 2020

Great, thanks @h3poteto !
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2020
@hakman hakman removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2020
@hakman hakman added the hacktoberfest-accepted Accepted contribution for Hacktoberfest label Oct 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: h3poteto, hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2020
@hakman
Copy link
Member

hakman commented Oct 15, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit d105c92 into kubernetes:master Oct 15, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Oct 15, 2020
@h3poteto h3poteto deleted the iss-9751 branch October 15, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman requested changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. hacktoberfest-accepted Accepted contribution for Hacktoberfest lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@h3poteto @k8s-ci-robot @hakman @johngmyers