Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs feature table not being rendered #10042

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Fix docs feature table not being rendered #10042

merged 1 commit into from
Oct 12, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Oct 12, 2020 •
edited
Loading

Feature tables are no longer generated correctly. Simplifying things seems to fix it.

Before fix:
https://kops.sigs.k8s.io/networking/calico/#configuring-wireguard

After fix:
https://5f83dda2c9e9d40008ce7f05--kubernetes-kops.netlify.app/networking/calico/#configuring-wireguard

/cc @MoShitrit @rifelpet @olemarkus

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/documentation approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 12, 2020
@hakman hakman force-pushed the fix-docs-feature-table branch from 56cf38b to e6e3fc1 Compare October 12, 2020 04:37
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 12, 2020
@moshevayner
Copy link
Member

/lgtm
Thanks @hakman!! 😄

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2020
@hakman
Copy link
Member Author

hakman commented Oct 12, 2020

Thanks @MoShitrit :)

@k8s-ci-robot k8s-ci-robot merged commit f0382be into kubernetes:master Oct 12, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Oct 12, 2020
@hakman hakman deleted the fix-docs-feature-table branch October 17, 2020 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moshevayner moshevayner Awaiting requested review from moshevayner

@olemarkus olemarkus Awaiting requested review from olemarkus

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@moshevayner moshevayner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@hakman @k8s-ci-robot @moshevayner