Open etcd port only when Calico uses "etcd" datastore #10032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakman
added
the
kind/cleanup
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
hakman
force-pushed
the
calico-firewall
branch
from
4c20a63 to
e0cfcf2
Compare
k8s-ci-robot
added
size/S
hakman
force-pushed
the
calico-firewall
branch
from
e0cfcf2 to
9c888bc
Compare
k8s-ci-robot
added
area/api
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Me too... |
|
/skip |
|
/retest |
|
Yeah. I fixed that for openstack, but that may have been easier than it is for AWS. I wanted to see how it goes with OS anyway before attempting the same on AWS. |
|
After this change I ended up with 2 rules: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For kubernetes 1.12+, kops hardcodes
DATASTORE_TYPEto "kubernetes".kops/upup/models/cloudup/resources/addons/networking.projectcalico.org/k8s-1.12.yaml.template
Line 36 in 5cc1b5a
kops/upup/models/cloudup/resources/addons/networking.projectcalico.org/k8s-1.12.yaml.template
Lines 763 to 764 in 5cc1b5a