Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spotinst: Upgrade the Spot Cluster Controller to version 1.0.67 #10011

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Spotinst: Upgrade the Spot Cluster Controller to version 1.0.67 #10011

merged 1 commit into from
Oct 2, 2020

Conversation

liranp
Copy link
Contributor

@liranp liranp commented Oct 1, 2020

This PR upgrades the Spot Cluster Controller to version 1.0.67 and stores the user credentials in a Secret instead of a ConfigMap.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 1, 2020
@liranp liranp force-pushed the feat-spot-controller-1.0.67 branch from a49775d to 15cc0fe Compare October 1, 2020 15:24
hakman
hakman reviewed Oct 2, 2020
View reviewed changes
upup/pkg/fi/cloudup/template_functions.go
Comment on lines 141 to 142
dest["SpotinstToken"] = func() string { return creds.Token }
dest["SpotinstAccount"] = func() string { return creds.Account }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these are used anywhere anymore.
Also, not quite sure how SPOTINST_ACCOUNT_LEGACY and SPOTINST_TOKEN_LEGACY are populated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are used in the older manifest that points to an older version of the controller. I've kept the legacy variables just to maintain backward compatibility with the ConfigMap.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thanks!

@hakman
Copy link
Member

hakman commented Oct 2, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, liranp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2020
@liranp
Copy link
Contributor Author

liranp commented Oct 2, 2020

@hakman Thank you for reviewing this!

@liranp
Copy link
Contributor Author

liranp commented Oct 2, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 25d736a into kubernetes:master Oct 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Oct 2, 2020
@liranp liranp deleted the feat-spot-controller-1.0.67 branch October 2, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman left review comments

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@liranp @hakman @k8s-ci-robot