Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openstack block device mapping support #7486

Closed
Teodor96 opened this issue Aug 29, 2019 · 5 comments
Closed

Openstack block device mapping support #7486

Teodor96 opened this issue Aug 29, 2019 · 5 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@Teodor96
Copy link

1. Describe IN DETAIL the feature/behavior/change you would like to see.
In our openstack installation we can't have flavours with root disk. The root disk is defined by the image at the time of creation of the instance and is mounted at the root at the time of creation. To support that in kops we can include the block_device_mapping_v2 options when creating an instance.

2. Feel free to provide a design supporting your feature request.
As an initial iteration we can have it as an on/off option on the instance group definitions. The options for the values needed by the block_device_mapping_v2 can be gathered from the image.

{
  "boot_index": "0",  # set to 0 always
  "delete_on_termination": true, # set to true always
  "destination_type": "volume", # set to volume 
  "device_name": "vda", # I believe we can default it to vda
  "source_type": "image", # Will always be image
  "uuid": "", # The id of the image
  "volume_size": 20
}

volume_size as a proof we can default it to the minimum size defined by the image and add it as an option later on.

I would add the option on the instance group as follows.

spec:
  osVolumeBoot:
    enabled: true
@zetaab
Copy link
Member

zetaab commented Aug 29, 2019

for me this sounds okay, feel free to make PR and verify it in your environment.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 27, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 27, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants