Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Best way to sync dependencies with dep? #5598

Closed
billpratt opened this issue Aug 10, 2018 · 3 comments
Closed

Question: Best way to sync dependencies with dep? #5598

billpratt opened this issue Aug 10, 2018 · 3 comments

Comments

@billpratt
Copy link

I've tried numerous ways to run dep ensure on this project. It seems to consistently hang and never finish. Is there a specific dep version I should be using? What is the best way to sync dependencies in the vendor folder?
@billpratt
Copy link
Author

billpratt commented Aug 12, 2018 •
edited
Loading

After more digging I found that dep ensure hangs on trying to sync a Prometheus dependency bitbucket.org/ww/goautoneg by running git ls-remote. This repo requires mercurial. After installing mercurial, I was able to proceed.

More info: prometheus/common#17

@justinsb
Copy link
Member

Yes - this is really frustrating - sorry!

I guess we could add a check for hg before syncing, but really that should be dep that does that! And I think we're likely to adopt vgo in the nearish future.

There is a makefile target, make dep-ensure , which also does the required dance with bazel run //:gazelle. We could add the check for hg there I guess!

justinsb added a commit to justinsb/kops that referenced this issue Aug 13, 2018
@justinsb
make dep-ensure checks that mercurial is installed
f38d220 
This only works if users use the makefile target, but it avoids a
likely failure mode of dep.

Fix kubernetes#5598
@justinsb justinsb mentioned this issue Aug 13, 2018
Merged
@justinsb
Copy link
Member

Sent #5600 to try to make this a bit better, if you're using make dep-ensure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justinsb @billpratt