Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kops always tries to delete the main AWS route table for a cluster #3828

Closed
blakebarnett opened this issue Nov 10, 2017 · 2 comments
Closed

Kops always tries to delete the main AWS route table for a cluster #3828

blakebarnett opened this issue Nov 10, 2017 · 2 comments
Labels
blocks-next

Comments

@blakebarnett
Copy link

Kops verison: 1.8.0-beta.1
K8s version: 1.7.x - 1.8.x

If a routing table is tagged as kubernetes.io/cluster/<cluster name>: shared, kops should ignore it when deleting the cluster. Currently if you tag all subnets and NAT gateways as shared this way it ignores the route tables associated with them but still attempts to delete the single route table with the name that matches the cluster no matter how it's tagged.
@georgebuckerfield
Copy link
Contributor

I'm up for working on this unless someone else has taken it on.

@blakebarnett
Copy link
Author

Go for it, 1st PR wins :)

@georgebuckerfield georgebuckerfield mentioned this issue Nov 17, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Nov 22, 2017
Merge pull request #3887 from georgebuckerfield/fix-routetable-deletion
cabe972 
Automatic merge from submit-queue.

Respect the shared tag when deleting route tables

Fixes #3828.

Modifies the `buildTrackerForRouteTable` function (used by `ListRouteTables`) to set the `Shared` field of each returned route table resource, based on the presence of the `kubernetes.io/cluster/<clustername>: shared` tag. This prevents route tables with this tag from being deleted.

WIP while I add some more tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocks-next
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justinsb @blakebarnett @georgebuckerfield