Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform bug is fixed -> Doc update #281

Closed
stephanlindauer opened this issue Aug 8, 2016 · 4 comments
Closed

Terraform bug is fixed -> Doc update #281

stephanlindauer opened this issue Aug 8, 2016 · 4 comments
Labels
area/documentation area/terraform Issues or PRs related to the Terraform target
Milestone

Comments

@stephanlindauer
Copy link

The terraform bug, mentioned in the README.md is fixed and should probably not be mentioned in the README.md anymore but rather kops should have a dependency to terraform >= 7.0

More info regarding the bug:
hashicorp/terraform#2143

@justinsb
Copy link
Member

justinsb commented Aug 8, 2016

Do you know of any way we can enforce that a terraform manifest is only for version >= X? I worry that we have to keep advertising it because most people won't be on 0.7 for the while, and terraform fails silently for < 0.7.

I agree we can put the workaround into a child page though, but at least for now we probably have to keep the notice pretty prominent.

@justinsb justinsb added this to the 1.3.0 milestone Aug 15, 2016
@justinsb
Copy link
Member

Going to rejig the docs, and hopefully everyone will update quickly. But AFAICT there's not version annotation in 0.7, so I can't remove it entirely:

hashicorp/terraform#4092
hashicorp/terraform#1400

I'm a little wary of the trick in hashicorp/terraform#4092 (comment)

justinsb added a commit to justinsb/kops that referenced this issue Aug 15, 2016
@justinsb
Copy link
Member

Moving further work on this (e.g. locking to a particular version) to the backlog

@justinsb justinsb modified the milestones: backlog, 1.3.0 Aug 15, 2016
@justinsb justinsb added the area/terraform Issues or PRs related to the Terraform target label Jan 7, 2017
@chrislovecnm
Copy link
Contributor

We specify version and the docs are updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation area/terraform Issues or PRs related to the Terraform target
Projects
None yet
Development

No branches or pull requests

3 participants