Skip to content

Commit

Permalink
prevent verify-misspelling failing on releases
Browse files Browse the repository at this point in the history
Removes pull request subjects from release notes and checks
the remainder of text.
  • Loading branch information
Mikulas committed Aug 16, 2018
1 parent 5af0b32 commit da506fc
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -517,12 +517,16 @@ verify-gofmt:
verify-packages: ${BINDATA_TARGETS}
hack/verify-packages.sh

# check code and docs inplace, then find release notes, remove PR titles and run misspell against the remaining text
.PHONY: verify-misspelling
verify-misspelling:
@which misspell 2>/dev/null ; if [ $$? -eq 1 ]; then \
go get -u github.com/client9/misspell/cmd/misspell; \
fi
@find . -type f \( -name "*.go*" -o -name "*.md*" \) -a \( -not -path "./vendor/*" -not -path "./_vendor/*" \) | \
@mkdir -p .build/docs
@find . -type f \( -name "*.go*" -o -name "*.md*" \) -a -path "./docs/releases/*" -exec basename {} \; | \
xargs -I{} sh -c 'sed -e "/^\* .*github.com\/kubernetes\/kops\/pull/d" docs/releases/{} > .build/docs/$(basename {})'
@find . -type f \( -name "*.go*" -o -name "*.md*" \) -a \( -not -path "./vendor/*" -not -path "./_vendor/*" -not -path "./docs/releases/*" \) | \
sed -e /README-ES.md/d -e /node_modules/d | \
xargs misspell -error

Expand Down

0 comments on commit da506fc

Please sign in to comment.