Skip to content

Commit

Permalink
Merge pull request #3084 from AlexB138/master
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue

Striking unnecessary conversion-gen instruction

Spoke with @chrislovecnm about this. go2idl is installed out of vendor/k8s.io/kubernetes/cmd/libs/go2idl/conversion-gen in the Makefile. It is not necessary to install it explicitly and the current instruction is incorrect.
  • Loading branch information
Kubernetes Submit Queue authored Jul 28, 2017
2 parents 6406aba + e84791a commit d9427cf
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions docs/development/api_updates.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ go get k8s.io/kubernetes
cd ${GOPATH}/src/k8s.io/kubernetes
git checkout master
git pull
go install ./cmd/libs/go2idl/conversion-gen
```

Then you can run `make apimachinery && make` to update the generated API machinery code (conversion functions). Note
Expand All @@ -36,4 +35,4 @@ it is backwards compatible (you have to make sure that the field is optional).

Currently, the apimachinery code we check in is relatively stable. However, when the generated code is large,
it is often considered good manners to your code reviewer to split a PR into multiple commits: one with the
actual changes, and then a second commit with the autogenerated code.
actual changes, and then a second commit with the autogenerated code.

0 comments on commit d9427cf

Please sign in to comment.