Skip to content

Commit

Permalink
Merge pull request #3771 from chrislovecnm/deprecating-kube-dns-api
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue.

deprecated API values that are no longer used with kube-dns

Fixes: #2909

`Image` and `Replicas` are not used.
  • Loading branch information
Kubernetes Submit Queue authored Nov 5, 2017
2 parents 40a94a7 + 9647b1d commit d2895be
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 3 deletions.
2 changes: 2 additions & 0 deletions pkg/apis/kops/cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -266,8 +266,10 @@ type LoadBalancerAccessSpec struct {
// KubeDNSConfig defines the kube dns configuration
type KubeDNSConfig struct {
// Image is the name of the docker image to run
// Deprecated as this is now in the addon
Image string `json:"image,omitempty"`
// Replicas is the number of pod replicas
// Deprecated as this is now in the addon, and controlled by autoscaler
Replicas int `json:"replicas,omitempty"`
// Domain is the dns domain
Domain string `json:"domain,omitempty"`
Expand Down
2 changes: 2 additions & 0 deletions pkg/apis/kops/v1alpha1/cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,10 @@ type LoadBalancerAccessSpec struct {
// KubeDNSConfig defines the kube dns configuration
type KubeDNSConfig struct {
// Image is the name of the docker image to run
// Deprecated as this is now in the addon
Image string `json:"image,omitempty"`
// Replicas is the number of pod replicas
// Deprecated as this is now in the addon, and controlled by autoscaler
Replicas int `json:"replicas,omitempty"`
// Domain is the dns domain
Domain string `json:"domain,omitempty"`
Expand Down
2 changes: 2 additions & 0 deletions pkg/apis/kops/v1alpha2/cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,10 @@ type LoadBalancerAccessSpec struct {

type KubeDNSConfig struct {
// Image is the name of the docker image to run
// Deprecated as this is now in the addon
Image string `json:"image,omitempty"`

// Deprecated as this is now in the addon, and controlled by autoscaler
Replicas int `json:"replicas,omitempty"`
Domain string `json:"domain,omitempty"`
ServerIP string `json:"serverIP,omitempty"`
Expand Down
3 changes: 0 additions & 3 deletions pkg/model/components/kubedns.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,6 @@ func (b *KubeDnsOptionsBuilder) BuildOptions(o interface{}) error {
}
clusterSpec.KubeDNS.ServerIP = ip.String()
clusterSpec.KubeDNS.Domain = clusterSpec.ClusterDNSDomain
// TODO: Once we start shipping more images, start using them
// TODO we need to pull this as this is no longer used
clusterSpec.KubeDNS.Image = "gcr.io/google_containers/kubedns-amd64:1.3"

return nil
}

0 comments on commit d2895be

Please sign in to comment.