Skip to content

Commit

Permalink
Merge pull request #3846 from KashifSaadat/coreos-logrotate
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue.

Fix CoreOS logrotate service failure.

The switch statement was incorrect, causing a bad logrotate unit file to be created for CoreOS.
  • Loading branch information
Kubernetes Submit Queue authored Nov 13, 2017
2 parents 5379888 + 1fdbbec commit 8315d65
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions nodeup/pkg/model/logrotate.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,7 @@ func (b *LogrotateBuilder) Build(c *fi.ModelBuilderContext) error {
// addLogrotateService creates a logrotate systemd task to act as target for the timer, if one is needed
func (b *LogrotateBuilder) addLogrotateService(c *fi.ModelBuilderContext) error {
switch b.Distribution {
case distros.DistributionCoreOS:
case distros.DistributionContainerOS:
case distros.DistributionCoreOS, distros.DistributionContainerOS:
// logrotate service already exists
return nil
}
Expand Down

0 comments on commit 8315d65

Please sign in to comment.