Skip to content

Commit

Permalink
Show warm pool nodes in get instances
Browse files Browse the repository at this point in the history
  • Loading branch information
Ole Markus With committed Apr 13, 2021
1 parent a4a7874 commit 69ef5bf
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
6 changes: 5 additions & 1 deletion cmd/kops/get_instances.go
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,11 @@ func instanceOutputTable(instances []*cloudinstances.CloudInstance, out io.Write
t.AddColumn("MACHINE-TYPE", func(i *cloudinstances.CloudInstance) string {
return i.MachineType
})
columns := []string{"ID", "NODE-NAME", "STATUS", "ROLES", "INTERNAL-IP", "INSTANCE-GROUP", "MACHINE-TYPE"}
t.AddColumn("STATE", func(i *cloudinstances.CloudInstance) string {
return string(i.State)
})

columns := []string{"ID", "NODE-NAME", "STATUS", "ROLES", "INTERNAL-IP", "INSTANCE-GROUP", "MACHINE-TYPE", "STATE"}
return t.Render(instances, os.Stdout, columns...)
}

Expand Down
3 changes: 0 additions & 3 deletions upup/pkg/fi/nodeup/command.go
Original file line number Diff line number Diff line change
Expand Up @@ -669,15 +669,12 @@ func getNodeConfigFromServer(ctx context.Context, config *nodeup.ConfigServerOpt
}

func getAWSConfigurationMode(c *model.NodeupModelContext) (string, error) {
<<<<<<< HEAD
// Only worker nodes and apiservers can actually autoscale.
// We are not adding describe permissions to the other roles
role := c.InstanceGroup.Spec.Role
if role != api.InstanceGroupRoleNode && role != api.InstanceGroupRoleAPIServer {
return "", nil
}
=======
>>>>>>> 46f3f10432... Don't start kubelet if we are warming

svc := c.Cloud.(awsup.AWSCloud).Autoscaling()

Expand Down

0 comments on commit 69ef5bf

Please sign in to comment.