Add headless service type label #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
close #851 |
cdrage
requested changes
Apr 12, 2018
docs/user-guide.md
Outdated
| | kompose.service.expose | true / hostname | | ||
| | kompose.service.expose.tls-secret | secret name | | ||
| | kompose.volume.size | kubernetes supported volume size | | ||
|
|
||
| **Note**: `kompose.service.type` label should be defined with `ports` only, otherwise `kompose` will fail. | ||
| **Note**: `kompose.service.type` label should be defined with `ports` only(except for headless service), otherwise `kompose` will fail. |
There was a problem hiding this comment.
add spacing between only and (except)
| @@ -33,6 +33,9 @@ const ( | |||
| LabelServiceExpose = "kompose.service.expose" | |||
| // LabelServiceExposeTLSSecret provides the name of the TLS secret to use with the Kubernetes ingress controller | |||
| LabelServiceExposeTLSSecret = "kompose.service.expose.tls-secret" | |||
|
|
|||
| // ServiceTypeHeadless... | |||
| ServiceTypeHeadless = "Headless" | |||
There was a problem hiding this comment.
most other variables are lowercase, should we use headless instead?
There was a problem hiding this comment.
This is a special case. Since kubernetes api does not have a "Headless' type, it has api.ServiceTypeClusterIP=ClusterIP.... This is var is only for internal use, others are custom labels that will show in the compose file
There was a problem hiding this comment.
That makes sense.. This LGTM then!
| if service.ExposeService != "" { | ||
| objects = append(objects, o.initRoute(name, service, svc.Spec.Ports[0].Port)) | ||
| } | ||
| } else { |
hangyan
force-pushed
the
restart-and-service
branch
2 times, most recently
from
c9d0c17 to
7bc512a
Compare
Also remove the relation between restart and service create
hangyan
force-pushed
the
restart-and-service
branch
from
20ba920 to
f3412a7
Compare
|
LGTM! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the relation between restart and service create