Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deploy resources parse error #960

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Fix deploy resources parse error #960

merged 1 commit into from
Mar 19, 2018

Conversation

hangyan
Copy link
Contributor

@hangyan hangyan commented Mar 15, 2018

fix #959

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 15, 2018
@hangyan hangyan force-pushed the fix-resources-limits-error branch from 0fb7590 to 6e5b6a3 Compare March 15, 2018 06:00
@hangyan
Copy link
Contributor Author

hangyan commented Mar 17, 2018

@cdrage

@cdrage
Copy link
Member

cdrage commented Mar 19, 2018

This LGTM. Thanks @hangyan !

@cdrage cdrage merged commit 90f6d89 into kubernetes:master Mar 19, 2018
@cdrage cdrage mentioned this pull request Mar 19, 2018
Closed
@hangyan hangyan deleted the fix-resources-limits-error branch March 31, 2018 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surajnarwade surajnarwade surajnarwade approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
4 participants
@hangyan @cdrage @surajnarwade @k8s-ci-robot