Fix custom output and charts conflict error #938
Conversation
k8s-ci-robot
added
size/L
hangyan
force-pushed
the
fix-helm-custom-dir
branch
from
7aa95dd to
7f9721e
Compare
|
To be honest @hangyan I don't think there are any tests written at the moment for charts. I'll review this soon however and test it out before we merge this in! |
hangyan
force-pushed
the
fix-helm-custom-dir
branch
from
860e952 to
f05fac6
Compare
|
@cdrage I have add some simple tests for charts and cutom output working together, I think it's enough for now |
| finalDirName = dirName + string(os.PathSeparator) + "templates" | ||
| } | ||
|
|
||
| log.Infof("YAML results in : %s", finalDirName) |
There was a problem hiding this comment.
Is this suppose to be debug information?
There was a problem hiding this comment.
If not, it may be better to indicate that this is where the chart information will be :) For example: Chart files located at: %s", finalDirName or something along those lines.
There was a problem hiding this comment.
@cdrage updated, remove the debug information, thanks very much!
hangyan
force-pushed
the
fix-helm-custom-dir
branch
from
b40db74 to
250d833
Compare
hangyan
force-pushed
the
fix-helm-custom-dir
branch
from
250d833 to
0f3d368
Compare
|
Thanks so much for all these recent contributions! Tests pass and code LGTM 👍 |
|
@cdrage Glad that I can help, hoping to do more contribute to this greate project |
fix #886
@cdrage I didn't find a correct way to add test for this change. So can you help me with this?
After this change, the logic now becomes:
assume there is a yaml in /tmp/a.yaml