improve error output of git commands

[cortex3]

What type of PR is this?

/kind feature

What this PR does / why we need it:

improves error output of git commands see #1957 for context.
Example:
current output:

FATA initBuildConfig failed: clibuildconfig cannot be created due to error in creating build context, getAbsBuildContext failed: exit status 128

with my PR:

FATA initBuildConfig failed: clibuildconfig cannot be created due to error in creating build context, getAbsBuildContext failed: fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Which issue(s) this PR fixes:

Fixes #1957

Special notes for your reviewer:

[k8s-ci-robot]

Welcome @cortex3!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[cdrage]

Missing a unit test, is there any way you can possibly do a simple one for utils_test.go?

Otherwise, the code looks great! :)

[cortex3]

Hi @cdrage,
I noticed that there are already unit tests for the openshift utils.go. They are just a bit hidden away because they have been included in the openshift_test.go:

kompose/pkg/transformer/openshift/openshift_test.go

Line 256 in 922f5aa

func TestGetAbsBuildContext(t *testing.T) {

The tests are still passing but let me know if you want me to extend them in any way.

[cdrage]

Hi @cdrage, I noticed that there are already unit tests for the openshift utils.go. They are just a bit hidden away because they have been included in the openshift_test.go:

kompose/pkg/transformer/openshift/openshift_test.go

Line 256 in 922f5aa

func TestGetAbsBuildContext(t *testing.T) {

The tests are still passing but let me know if you want me to extend them in any way.

Honestly, tests are passing and this adds crucial information for the openshift section (which needs improvement to be honest...), this LGTM.

[cdrage]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, cortex3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cdrage]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cdrage]

/lgtm