-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 1942 #1950
Fix issue 1942 #1950
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @hurzelpurzel! |
Thank you for the fix as well as the fix with compiling / mod go 🚀 🚀 🚀 🚀 🚀 🚀 |
This code LGTM! |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage, hurzelpurzel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
PVC names will now in the valid format
Which issue(s) this PR fixes:
Fixes # 1942
Special notes for your reviewer:
go.mod was changed to point to a valid openshift api version