Fix loading env file #1679
Merged
Fix loading env file #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
approved
AhmedGrati
force-pushed
the
fix-loading-env_file
branch
2 times, most recently
from
241defc to
130727f
Compare
Signed-off-by: AhmedGrati <[email protected]>
AhmedGrati
force-pushed
the
fix-loading-env_file
branch
3 times, most recently
from
fcec73c to
7bb69be
Compare
k8s-ci-robot
added
size/XXL
AhmedGrati
force-pushed
the
fix-loading-env_file
branch
3 times, most recently
from
3a2fbbf to
ebc1fc8
Compare
Signed-off-by: AhmedGrati <[email protected]>
AhmedGrati
force-pushed
the
fix-loading-env_file
branch
from
ebc1fc8 to
1b11f79
Compare
cdrage
approved these changes
Jul 26, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AhmedGrati, cdrage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hello, when will this be shipped? 🙏🏻 |
|
waiting for this pr too |
|
we are all waiting... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix the issue of converting/loading the env file from docker-compose
env_file.Which issue(s) this PR fixes:
Fixes #1678.
Special notes for your reviewer: