Fix environment variables interpolation #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 16, 2022 23:04
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
added 12 commits
October 16, 2022 23:17
This reverts commit c85f375.
This reverts commit cfe5c85.
…hub.com/AhmedGrati/kompose into fix-environment-variables-interpolation
k8s-ci-robot
added
size/L
k8s-ci-robot
added
size/M
k8s-ci-robot
added
size/L
|
Looks cool. Thanks @AhmedGrati |
hangyan
approved these changes
Nov 19, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AhmedGrati, hangyan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
9 tasks
n-rodriguez
added a commit
to jbox-web/squarectl
that referenced
this pull request
Jan 25, 2023
n-rodriguez
added a commit
to jbox-web/squarectl
that referenced
this pull request
Jan 27, 2023
n-rodriguez
added a commit
to jbox-web/squarectl
that referenced
this pull request
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request aims to solve #1497.
In the previous implementation, we were loading the
docker-composefile while activating variables interpolation, because we are using the default options of the Docker CLI Loader.Solution
To mitigate this problem, we need to disable the default interpolation, and then adapt the env variable to the K8S style. e.g:
$PROTOCOL=>$(PROTOCOL)