Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v3): Added network name normalisation in v3 parsing #1490

Merged
merged 1 commit into from
Mar 24, 2022
Merged

fix(v3): Added network name normalisation in v3 parsing #1490

merged 1 commit into from
Mar 24, 2022

Conversation

sergeyshevch
Copy link
Member

Fixes #1487
Current parsing of network names in v3 doesn't provide network name normalization that causes incorrect label names and incorrect networkpolicy resource name

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 21, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sergeyshevch / name: Sergey Shevchenko (734b88e)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 21, 2022
@k8s-ci-robot k8s-ci-robot requested review from ngtuna and sebgoa March 21, 2022 12:08
@sergeyshevch sergeyshevch force-pushed the feature/fix-network-normalization-in-v3 branch from db9e04f to 734b88e Compare March 21, 2022 12:08
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 21, 2022
@sergeyshevch
Copy link
Member Author

Also i provided updates in testcase for v3 version that checks that now normalization works correctly

@cdrage
Copy link
Member

cdrage commented Mar 22, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, sergeyshevch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2022
@sergeyshevch
Copy link
Member Author

/assign @cdrage

@kadel
Copy link
Member

kadel commented Mar 24, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit d976c81 into kubernetes:master Mar 24, 2022
@sergeyshevch sergeyshevch mentioned this pull request Apr 1, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrage cdrage cdrage approved these changes

@ngtuna ngtuna Awaiting requested review from ngtuna

@sebgoa sebgoa Awaiting requested review from sebgoa

Assignees

@kadel kadel

@cdrage cdrage

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can not convert _ of Network to -
4 participants
@sergeyshevch @cdrage @k8s-ci-robot @kadel