[]byte will use +%v through InfoS.

[njuptlzf]

/kind bug

What steps did you take and what happened:
[A clear and concise description of what the bug is.]

klog.InfoS("[]byte", "b1", []byte("hello world"))

print:
I0508 19:35:13.452661 57319 testKlog.go:11] "[]byte" b1=[104 101 108 108 111 32 119 111 114 108 100]

What did you expect to happen:
I0508 19:37:01.473191 2045 testKlog.go:11] "[]byte" b1="hello world"

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
part of kubernetes/kubernetes#101714
As k8s conducts structured log migration, InfoS is used more and more, but []byte, usually cooperates with %q before the migration, is it necessary to submit a PR so that []byte uses %q in InfoS?
Currently in InfoS, []byte uses %+v.

klog/klog.go

Line 832 in 0cc9b83

b.WriteString(fmt.Sprintf("%s=%+v", k, v))

If the idea is approved, I will do it, otherwise I will probably continue to use klog.InfoS("[]byte", "b1", string([]byte("hello world"))).

[yuzhiquan]

/assign

[yuzhiquan]

Oops, sorry @njuptlzf for not notice this If the idea is approved, I will do it, otherwise I will probably continue to use.

[njuptlzf]

Oops, sorry @njuptlzf for not notice this If the idea is approved, I will do it, otherwise I will probably continue to use.

Everything is for the development of the community, cheers. :)

[pohly]

This didn't solve the problem for JSON. There the byte slice will be dumped as a base64 encoded string representation of the bytes.

IMHO the right solution for byte slices that are meant to be treated like strings is to convert to string before logging.

Let's reopen to discuss this further. We may have to put this into the migration guide.

/reopen
/wg structured-logging

[k8s-ci-robot]

@pohly: Reopened this issue.

In response to this:

This didn't solve the problem for JSON. There the byte slice will be dumped as a base64 encoded string representation of the bytes.

IMHO the right solution for byte slices that are meant to be treated like strings is to convert to string before logging.

Let's reopen to discuss this further. We may have to put this into the migration guide.

/reopen
/wg structured-logging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[shivanshuraj1333]

Thanks, @pohly for pointing this out, I agree with

the right solution for byte slices that are meant to be treated like strings is to convert to string before logging.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[pohly]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[pohly]

We may have to put this into the migration guide.

We have that now, so let's assume that this is indeed resolved.

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.