Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prow-build-cluster: deploy cluster-autoscaler, metrics-server, and AWS Secrets Manager integration #4873

Merged
merged 6 commits into from
Mar 6, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Mar 5, 2023

Based on requirements stated in #4686, this PR ensures we deploy the following components in prow-build-cluster:

  • cluster-autoscaler
  • metrics-server
  • secrets-store-csi-driver and secrets-store-csi-driver-provider-aws (to provide AWS Secrets Manager integration)

All components are fully-managed by Terraform. Kubernetes YAML manifests were converted to Terraform (.tf) files using tfk8s and deployed using the hashicorp/kubernetes provider. Helm charts are reconciled using the hashicorp/helm provider.

IRSA (IAM role for Service Account) for Secrets Manager is commented and provided as a reference. It's supposed to uncommented and updated based on what we want to use the Secrets Manager for.

The reason for going with Terraform for everything is to:

  • avoid additional Bash scripts -- we deploy everything with a single terraform apply invocation
  • make it easy to replicate this setup and eventually deploy additional build clusters

This change is already reconciled. Additionally, the all three components were tested and are working well.

/assign @ameukam @upodroid

xmudrii added 5 commits March 5, 2023 01:47
Signed-off-by: Marko Mudrinić <[email protected]>
Signed-off-by: Marko Mudrinić <[email protected]>
Signed-off-by: Marko Mudrinić <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/infra Infrastructure management, infrastructure design, code in infra/ labels Mar 5, 2023
@k8s-ci-robot k8s-ci-robot requested review from dims and thockin March 5, 2023 00:56
@k8s-ci-robot k8s-ci-robot added area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 5, 2023
@ameukam
Copy link
Member

ameukam commented Mar 6, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit bab06ad into kubernetes:main Mar 6, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 6, 2023
@xmudrii xmudrii deleted the prow-build-cluster-components branch March 6, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants