Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Artifact Registry to Image Manifests - Part Eight #4308

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Add Artifact Registry to Image Manifests - Part Eight #4308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 31 additions & 5 deletions k8s.gcr.io/manifests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# GCR Manifests
# AR/GCR Manifests

This directory holds the manifest metadata for all of our sub-projects. These
files define the source and destination repos and paths that the promoter is
Expand All @@ -10,9 +10,35 @@ change.

Reviewers should ensure that:
* The source registry is one that we trust.
* There is one non-source registry for each of {us, eu, asia}.
* The non-source registries include an appropriate "subdir" for the
* The following destination registries must be specified:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like something a presubmit test should do for us to reduce review burden?

```
us.gcr.io/k8s-artifacts-prod
eu.gcr.io/k8s-artifacts-prod
asia.gcr.io/k8s-artifacts-prod
asia-east1-docker.pkg.dev/k8s-artifacts-prod/images
asia-south1-docker.pkg.dev/k8s-artifacts-prod/images
asia-northeast1-docker.pkg.dev/k8s-artifacts-prod/images
asia-northeast2-docker.pkg.dev/k8s-artifacts-prod/images
australia-southeast1-docker.pkg.dev/k8s-artifacts-prod/images
europe-north1-docker.pkg.dev/k8s-artifacts-prod/images
europe-southwest1-docker.pkg.dev/k8s-artifacts-prod/images
europe-west1-docker.pkg.dev/k8s-artifacts-prod/images
europe-west2-docker.pkg.dev/k8s-artifacts-prod/images
europe-west4-docker.pkg.dev/k8s-artifacts-prod/images
europe-west8-docker.pkg.dev/k8s-artifacts-prod/images
europe-west9-docker.pkg.dev/k8s-artifacts-prod/images
southamerica-west1-docker.pkg.dev/k8s-artifacts-prod/images
us-central1-docker.pkg.dev/k8s-artifacts-prod/images
us-east1-docker.pkg.dev/k8s-artifacts-prod/images
us-east4-docker.pkg.dev/k8s-artifacts-prod/images
us-east5-docker.pkg.dev/k8s-artifacts-prod/images
us-south1-docker.pkg.dev/k8s-artifacts-prod/images
us-west1-docker.pkg.dev/k8s-artifacts-prod/images
us-west2-docker.pkg.dev/k8s-artifacts-prod/images
```
* The destination registries must be appended with an appropriate "subdir" for the
sub-project (e.g. src `gcr.io/k8s-staging-foobar` promotes to
`{us,eu,asia}.gcr.io/k8s-artifacts-prod/foobar`). Exceptions to this are
very rare and must be commented and linked to a PR with discussion.
`eu.gcr.io/k8s-artifacts-prod/foobar`). Exceptions to this are
extremely rare and must be commented and linked to an issue or a PR with discussion.
* The service account is correct.
* Ensure the filename is `promoter-manifest.yaml`
40 changes: 40 additions & 0 deletions k8s.gcr.io/manifests/k8s-staging-sig-storage/promoter-manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,43 @@ registries:
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: asia.gcr.io/k8s-artifacts-prod/sig-storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: asia-east1-docker.pkg.dev/k8s-artifacts-prod/images/sig-storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: asia-south1-docker.pkg.dev/k8s-artifacts-prod/images/sig-storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: asia-northeast1-docker.pkg.dev/k8s-artifacts-prod/images/sig-storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: asia-northeast2-docker.pkg.dev/k8s-artifacts-prod/images/sig-storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: australia-southeast1-docker.pkg.dev/k8s-artifacts-prod/images/sig-storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: europe-north1-docker.pkg.dev/k8s-artifacts-prod/images/sig-storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: europe-southwest1-docker.pkg.dev/k8s-artifacts-prod/images/sig-storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: europe-west1-docker.pkg.dev/k8s-artifacts-prod/images/sig-storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: europe-west2-docker.pkg.dev/k8s-artifacts-prod/images/sig-storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: europe-west4-docker.pkg.dev/k8s-artifacts-prod/images/sig-storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: europe-west8-docker.pkg.dev/k8s-artifacts-prod/images/sig-storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: europe-west9-docker.pkg.dev/k8s-artifacts-prod/images/sig-storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: southamerica-west1-docker.pkg.dev/k8s-artifacts-prod/images/sig-storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: us-central1-docker.pkg.dev/k8s-artifacts-prod/images/sig-storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: us-east1-docker.pkg.dev/k8s-artifacts-prod/images/sig-storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: us-east4-docker.pkg.dev/k8s-artifacts-prod/images/sig-storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: us-east5-docker.pkg.dev/k8s-artifacts-prod/images/sig-storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: us-south1-docker.pkg.dev/k8s-artifacts-prod/images/sig-storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: us-west1-docker.pkg.dev/k8s-artifacts-prod/images/sig-storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: us-west2-docker.pkg.dev/k8s-artifacts-prod/images/sig-storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
40 changes: 40 additions & 0 deletions k8s.gcr.io/manifests/k8s-staging-slack-infra/promoter-manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,43 @@ registries:
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: asia.gcr.io/k8s-artifacts-prod/slack-infra
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: asia-east1-docker.pkg.dev/k8s-artifacts-prod/images/slack-infra
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: asia-south1-docker.pkg.dev/k8s-artifacts-prod/images/slack-infra
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: asia-northeast1-docker.pkg.dev/k8s-artifacts-prod/images/slack-infra
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: asia-northeast2-docker.pkg.dev/k8s-artifacts-prod/images/slack-infra
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: australia-southeast1-docker.pkg.dev/k8s-artifacts-prod/images/slack-infra
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: europe-north1-docker.pkg.dev/k8s-artifacts-prod/images/slack-infra
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: europe-southwest1-docker.pkg.dev/k8s-artifacts-prod/images/slack-infra
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: europe-west1-docker.pkg.dev/k8s-artifacts-prod/images/slack-infra
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: europe-west2-docker.pkg.dev/k8s-artifacts-prod/images/slack-infra
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: europe-west4-docker.pkg.dev/k8s-artifacts-prod/images/slack-infra
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: europe-west8-docker.pkg.dev/k8s-artifacts-prod/images/slack-infra
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: europe-west9-docker.pkg.dev/k8s-artifacts-prod/images/slack-infra
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: southamerica-west1-docker.pkg.dev/k8s-artifacts-prod/images/slack-infra
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: us-central1-docker.pkg.dev/k8s-artifacts-prod/images/slack-infra
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: us-east1-docker.pkg.dev/k8s-artifacts-prod/images/slack-infra
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: us-east4-docker.pkg.dev/k8s-artifacts-prod/images/slack-infra
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: us-east5-docker.pkg.dev/k8s-artifacts-prod/images/slack-infra
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: us-south1-docker.pkg.dev/k8s-artifacts-prod/images/slack-infra
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: us-west1-docker.pkg.dev/k8s-artifacts-prod/images/slack-infra
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: us-west2-docker.pkg.dev/k8s-artifacts-prod/images/slack-infra
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
Loading