Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Windows Operational Readiness container registry #4079

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Adding Windows Operational Readiness container registry #4079

merged 1 commit into from
Aug 19, 2022

Conversation

knabben
Copy link
Member

@knabben knabben commented Aug 15, 2022

Adding a k8s official repository for the kubernetes-sigs/windows-operational-readiness project

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/infra Infrastructure management, infrastructure design, code in infra/ area/k8s.gcr.io Code in k8s.gcr.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Aug 15, 2022
@k8s-ci-robot k8s-ci-robot requested a review from thockin August 15, 2022 17:38
@knabben knabben force-pushed the windows-op-readiness branch from 651b52e to ef943db Compare August 15, 2022 17:48
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 15, 2022
@marosset
Copy link
Contributor

/sig windows

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Aug 15, 2022
@knabben knabben force-pushed the windows-op-readiness branch from ef943db to e4de619 Compare August 15, 2022 18:28
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 15, 2022
@knabben knabben force-pushed the windows-op-readiness branch from e4de619 to 4f8b04e Compare August 15, 2022 18:34
marosset
marosset reviewed Aug 15, 2022
View reviewed changes
@knabben knabben force-pushed the windows-op-readiness branch 2 times, most recently from c8fab22 to d31f85f Compare August 16, 2022 12:35
@ameukam
Copy link
Member

ameukam commented Aug 16, 2022

@knabben We should ensure a Google Group exists in https://github.com/kubernetes/k8s.io/blob/main/groups/sig-windows/groups.yaml and added to the restrictions file: https://github.com/kubernetes/k8s.io/blob/main/groups/restrictions.yaml#L191-L194.

@knabben knabben force-pushed the windows-op-readiness branch from d31f85f to 02c8eeb Compare August 16, 2022 21:25
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2022
@knabben knabben force-pushed the windows-op-readiness branch from 02c8eeb to cc22465 Compare August 16, 2022 21:31
@marosset
Copy link
Contributor

LGMT from sig windows

@knabben
Copy link
Member Author

knabben commented Aug 18, 2022

/assign @nikhita

@ameukam
Copy link
Member

ameukam commented Aug 19, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, knabben

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit 78e5712 into kubernetes:main Aug 19, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 19, 2022
@ameukam
Copy link
Member

ameukam commented Aug 19, 2022

Project created:

...
      +- member: group:[email protected]
      +  role: roles/storage.objectAdmin
       - member: projectEditor:k8s-staging-win-op-rdnss
         role: roles/storage.legacyBucketOwner
       - member: projectOwner:k8s-staging-win-op-rdnss
      @@ -4,6 +4,8 @@
         role: roles/storage.legacyBucketOwner
       - member: group:[email protected]
         role: roles/storage.objectAdmin
      +- member: group:[email protected]
      +  role: roles/storage.legacyBucketWriter
       - member: group:[email protected]
         role: roles/storage.objectAdmin
       - member: projectEditor:k8s-staging-win-op-rdnss
    Ensuring [email protected] can use GCB in project: k8s-staging-win-op-rdnss 
    Updated IAM policy for project [k8s-staging-win-op-rdnss].
    @@ -1,5 +1,7 @@
     - member: group:[email protected]
       role: roles/viewer
    +- member: group:[email protected]
    +  role: roles/cloudbuild.builds.editor
     - member: group:[email protected]
       role: roles/viewer
     - member: serviceAccount:[email protected]
    Updated IAM policy for project [k8s-staging-win-op-rdnss].
    @@ -2,6 +2,8 @@
       role: roles/viewer
     - member: group:[email protected]
       role: roles/cloudbuild.builds.editor
    +- member: group:[email protected]
    +  role: roles/serviceusage.serviceUsageConsumer
     - member: group:[email protected]
       role: roles/viewer
     - member: serviceAccount:[email protected]
    Ensuring [email protected] can use GCB in project: k8s-staging-win-op-rdnss 
    Updated IAM policy for project [k8s-staging-win-op-rdnss].
    @@ -8,6 +8,8 @@
       role: roles/viewer
     - member: serviceAccount:[email protected]
       role: roles/cloudbuild.builds.builder
    +- member: serviceAccount:[email protected]
    +  role: roles/cloudbuild.builds.builder
     - member: serviceAccount:k8s-infra-gcr-vuln-scanning@k8s-artifacts-prod.iam.gserviceaccount.com
       role: roles/containeranalysis.occurrences.viewer
     - member: serviceAccount:[email protected]
    @@ -14,3 +14,5 @@
       role: roles/storage.legacyBucketOwner
     - member: projectViewer:k8s-staging-win-op-rdnss
       role: roles/storage.legacyBucketReader
    +- member: serviceAccount:[email protected]
    +  role: roles/storage.objectCreator
    @@ -16,3 +16,5 @@
       role: roles/storage.legacyBucketReader
     - member: serviceAccount:[email protected]
       role: roles/storage.objectCreator
    +- member: serviceAccount:[email protected]
    +  role: roles/storage.objectViewer
Configuring special cases for Release Managers 
  Empowering [email protected] as project viewers in k8s-staging-artifact-promoter 
  Empowering [email protected] as project viewers in k8s-staging-build-image 
  Empowering [email protected] as project viewers in k8s-staging-ci-images 
  Empowering [email protected] as project viewers in k8s-staging-cip-test 
  Empowering [email protected] as project viewers in k8s-staging-experimental 
  Empowering [email protected] as project viewers in k8s-staging-kubernetes 
  Empowering kubernetes-release-test GCB service account to admin GCR 
  Empowering [email protected] as project viewers in k8s-staging-releng 
  Empowering [email protected] as project viewers in k8s-staging-releng-test 
  Empowering [email protected] as project viewers in k8s-staging-publishing-bot 
Done

@knabben knabben deleted the windows-op-readiness branch August 19, 2022 15:12
@ameukam ameukam mentioned this pull request Aug 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marosset marosset marosset left review comments

@thockin thockin Awaiting requested review from thockin

Assignees

@ameukam ameukam

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/groups Google Groups management, code in groups/ area/infra Infrastructure management, infrastructure design, code in infra/ area/k8s.gcr.io Code in k8s.gcr.io/ area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
5 participants
@knabben @marosset @ameukam @k8s-ci-robot @nikhita