Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS requirement for registry.k8s.io buckets #3643

Conversation

BobyMCbobs
Copy link
Member

Disables the use of HTTP in favor of HTTPS for S3 bucket connections

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Apr 19, 2022
@k8s-ci-robot k8s-ci-robot requested review from spiffxp and thockin April 19, 2022 02:47
@BobyMCbobs
Copy link
Member Author

Related to #3620

@ameukam
Copy link
Member

ameukam commented Apr 19, 2022

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, BobyMCbobs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3f6392a into kubernetes:main Apr 19, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Apr 19, 2022
@BobyMCbobs
Copy link
Member Author

/lgtm /approve

Thank you @ameukam!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants