Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add k8s-infra-cluster-operators-test google group. #276

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Add k8s-infra-cluster-operators-test google group. #276

merged 1 commit into from
Jun 11, 2019

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Jun 11, 2019

Reference issue : #275

The purpose of this Google group is to test the Google Group for GKE
feature.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. wg/k8s-infra labels Jun 11, 2019
@k8s-ci-robot k8s-ci-robot requested review from dims and spiffxp June 11, 2019 08:56
@ameukam ameukam mentioned this pull request Jun 11, 2019
Closed
dims
dims reviewed Jun 11, 2019
View reviewed changes
groups/groups.yaml Outdated
@@ -27,6 +27,11 @@ groups:
- [email protected]
- [email protected]
- [email protected]
- email-id: [email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ameukam let's drop the -test. Also please add me [email protected] to help with setup/trouble shooting etc. Did you forget to add your id?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to exclude myself from the testers. :-D

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please include me as well (spiffxp@google)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spiffxp @dims I included the changes requested.

@ameukam
Add k8s-infra-cluster-operators google group.
6531953 
Define the group of people allowed to operate the GKE clusters.
The first step is to understand how the Google Groups for GKE feature is
working.
@dims
Copy link
Member

dims commented Jun 11, 2019

@ameukam once this group is created ... what's the next step?

@dims
Copy link
Member

dims commented Jun 11, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2a24162 into kubernetes:master Jun 11, 2019
@dims
Copy link
Member

dims commented Jun 11, 2019

@ameukam - group is ready

@ameukam
Copy link
Member Author

ameukam commented Jun 11, 2019

@dims The next steps would be to :

  • create a GKE cluster in a project associated with the organization that manages kubernetes.io.
  • create the RBAC resources to identify what policies we can setup for this cluster.

@dims
Copy link
Member

dims commented Jun 11, 2019

@ameukam Ack, so wanna ping @thockin / @justinsb for those?

@ameukam
Copy link
Member Author

ameukam commented Jun 11, 2019

@dims Firstly, i want people review this script. I'm not sure i followed the best practices; many things are hard-coded in this script.

@spiffxp spiffxp mentioned this pull request Jun 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ameukam @dims @k8s-ci-robot @spiffxp