audit: update as of 2021-09-13 #2705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/audit
k8s-infra-ci-robot
changed the title
k8s-infra-ci-robot
force-pushed
the
autoaudit-prow
branch
from
a37385b to
1af76da
Compare
k8s-ci-robot
added
size/L
k8s-infra-ci-robot
changed the title
k8s-infra-ci-robot
force-pushed
the
autoaudit-prow
branch
4 times, most recently
from
0d1f3a5 to
b300eb5
Compare
k8s-infra-ci-robot
changed the title
k8s-infra-ci-robot
force-pushed
the
autoaudit-prow
branch
3 times, most recently
from
be9c576 to
7019d6b
Compare
k8s-infra-ci-robot
force-pushed
the
autoaudit-prow
branch
from
7019d6b to
451ff51
Compare
spiffxp
approved these changes
Sep 13, 2021
Comment on lines
-19
to
+26
| "group:[email protected]" | ||
| "serviceAccount:[email protected]" | ||
| ], | ||
| "role": "roles/storage.legacyBucketWriter" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "group:[email protected]", | ||
| "serviceAccount:[email protected]" |
Comment on lines
+1
to
+8
| { | ||
| "displayName": "artifact promoter", | ||
| "email": "[email protected]", | ||
| "name": "projects/k8s-artifacts-prod/serviceAccounts/[email protected]", | ||
| "oauth2ClientId": "115345552404607443038", | ||
| "projectId": "k8s-artifacts-prod", | ||
| "uniqueId": "115345552404607443038" | ||
| } |
| { | ||
| "members": [ | ||
| "serviceAccount:k8s-infra-prow-build-trusted.svc.id.goog[test-pods/k8s-infra-promoter]", | ||
| "serviceAccount:k8s-prow.svc.id.goog[test-pods/k8s-infra-promoter]" |
There was a problem hiding this comment.
Ideally we can drop the k8s-prow binding v soon
Comment on lines
+1
to
+18
| [ | ||
| { | ||
| "role": "WRITER", | ||
| "specialGroup": "projectWriters" | ||
| }, | ||
| { | ||
| "role": "OWNER", | ||
| "specialGroup": "projectOwners" | ||
| }, | ||
| { | ||
| "role": "OWNER", | ||
| "userByEmail": "[email protected]" | ||
| }, | ||
| { | ||
| "role": "READER", | ||
| "specialGroup": "projectReaders" | ||
| } | ||
| ] |
There was a problem hiding this comment.
This looks like ii work but I don't see a terraform resource for this
Comment on lines
-23
to
+24
| "currentMasterVersion": "1.20.8-gke.2100", | ||
| "currentNodeVersion": "1.20.8-gke.2100", | ||
| "currentMasterVersion": "1.20.9-gke.701", | ||
| "currentNodeVersion": "1.20.8-gke.2100 *", |
There was a problem hiding this comment.
Cluster updated patch release versions during the most recent maintenance window
Comment on lines
+6
to
+9
| monitoring.googleapis.com Cloud Monitoring API | ||
| pubsub.googleapis.com Cloud Pub/Sub API | ||
| secretmanager.googleapis.com Secret Manager API | ||
| stackdriver.googleapis.com Stackdriver API |
There was a problem hiding this comment.
Um, I think this was me, visiting the monitoring dashboard for this project, trying to get a sense of the traffic graphs. I'll manually disable and see what happens
There was a problem hiding this comment.
gcloud services disable --force monitoring.googleapis.com --project=k8s-staging-ci-images
gcloud services disable --force stackdriver.googleapis.com --project=k8s-staging-ci-images
| @@ -1,6 +1,7 @@ | |||
| NAME TITLE | |||
| bigquery.googleapis.com BigQuery API | |||
| bigquerystorage.googleapis.com BigQuery Storage API | |||
| billingbudgets.googleapis.com Cloud Billing Budget API | |||
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k8s-infra-ci-robot, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audit Updates wg-k8s-infra