Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps/k8s.io: flip go.k8s.io/triage to community-owned bucket #2544

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 16, 2021

Related:

/hold
Waiting to see successful triage run at: https://testgrid.k8s.io/wg-k8s-infra-canaries#triage

This also addresses some post-review nits from @sftim on #2461

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/apps Application management, code in apps/ area/infra Infrastructure management, infrastructure design, code in infra/ labels Aug 16, 2021
@k8s-ci-robot k8s-ci-robot added area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Aug 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 16, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Aug 16, 2021

/cc @ameukam @sftim

@k8s-ci-robot k8s-ci-robot requested review from ameukam and sftim August 16, 2021 14:27
@ameukam
Copy link
Member

ameukam commented Aug 16, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Aug 16, 2021

/hold cancel
Job is passing

There is no data because kettle has been down for >2 weeks so there are no failures available to cluster

But it is working, e.g. https://storage.googleapis.com/k8s-triage/index.html?date=2021-07-09

There will be a companion test-infra PR to redirect the old k8s-gubernator links to this new bucket

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2164997 into kubernetes:main Aug 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 16, 2021
@spiffxp spiffxp deleted the k8s-triage-flip branch August 16, 2021 16:06
@spiffxp
Copy link
Member Author

spiffxp commented Aug 16, 2021

Deploy failed

AssertionError: 'https://storage.googleapis.com/k8s-triage/index.html' != 'https://storage.googleapis.com/k8s-gubernator/triage/index.html'
- https://storage.googleapis.com/k8s-triage/index.html
+ https://storage.googleapis.com/k8s-gubernator/triage/index.html
?                                    +++++++++++
 : 
GET "http://go.kubernetes.io/triage" got an unexpected redirect location:
 want: https://storage.googleapis.com/k8s-gubernator/triage/index.html
 got:  https://storage.googleapis.com/k8s-triage/index.html

Opened #2547 to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apps Application management, code in apps/ area/infra Infrastructure management, infrastructure design, code in infra/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants