Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps/kubernetes-external-secrets: update to 8.2.3 #2431

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jul 30, 2021

@k8s-ci-robot k8s-ci-robot requested review from nikhita and thockin July 30, 2021 15:08
@k8s-ci-robot k8s-ci-robot added wg/k8s-infra cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 30, 2021

/cc @dims @ameukam

@k8s-ci-robot k8s-ci-robot requested review from ameukam and dims July 30, 2021 15:10
@ameukam
Copy link
Member

ameukam commented Jul 30, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4b230b3 into kubernetes:main Jul 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 30, 2021
@spiffxp spiffxp deleted the bump-aaa-k-e-s branch July 30, 2021 15:13
@spiffxp
Copy link
Member Author

spiffxp commented Jul 30, 2021

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-k8sio-deploy-app-kubernetes-external-secrets/1421126349497569280

OK so this is the same problem as #2218

I really want to find a way to let prow deploy RBAC rules without allowing it to delete the cluster it's deploying to...

@spiffxp
Copy link
Member Author

spiffxp commented Jul 30, 2021

Manually deployed for now to make sure we're not in a broken state

spiffxp@cloudshell:~/k8s.io/apps/kubernetes-external-secrets (kubernetes-public)$ ./deploy.sh
serviceaccount/kubernetes-external-secrets unchanged
service/kubernetes-external-secrets-metrics unchanged
deployment.apps/kubernetes-external-secrets unchanged
customresourcedefinition.apiextensions.k8s.io/externalsecrets.kubernetes-client.io unchanged
clusterrole.rbac.authorization.k8s.io/kubernetes-external-secrets configured
clusterrolebinding.rbac.authorization.k8s.io/kubernetes-external-secrets unchanged
clusterrolebinding.rbac.authorization.k8s.io/kubernetes-external-secrets-auth unchanged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants