Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps/slack-infra: fix deploy.sh #2428

Merged
merged 1 commit into from
Jul 30, 2021
Merged

apps/slack-infra: fix deploy.sh #2428

merged 1 commit into from
Jul 30, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jul 30, 2021 •
edited
Loading

Related:

Noticed while watching #2425 deploy

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. wg/k8s-infra labels Jul 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2021
@k8s-ci-robot k8s-ci-robot requested review from nikhita and thockin July 30, 2021 14:27
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 30, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 30, 2021

/cc @dims @ameukam
/cc @mrbobbytables

@mrbobbytables
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit b31591b into kubernetes:main Jul 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 30, 2021
@spiffxp spiffxp deleted the fix-slack-infra-deploy branch July 30, 2021 14:51
@spiffxp spiffxp mentioned this pull request Jul 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita Awaiting requested review from nikhita

@thockin thockin Awaiting requested review from thockin

@ameukam ameukam Awaiting requested review from ameukam

@dims dims Awaiting requested review from dims

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

Assignees

@mrbobbytables mrbobbytables

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @mrbobbytables