Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: update as of 2021-07-28 #2385

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Conversation

cncf-ci
Copy link
Contributor

@cncf-ci cncf-ci commented Jul 22, 2021

Audit Updates wg-k8s-infra

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 22, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @cncf-ci. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 22, 2021
@k8s-ci-robot k8s-ci-robot requested review from nikhita and spiffxp July 22, 2021 01:05
@k8s-ci-robot k8s-ci-robot added area/audit Audit of project resources, audit followup issues, code in audit/ wg/k8s-infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 22, 2021
@cncf-ci cncf-ci force-pushed the autoaudit-prow branch 4 times, most recently from 9717030 to 218fb14 Compare July 22, 2021 22:09
@cncf-ci cncf-ci changed the title audit: update as of 2021-07-22 audit: update as of 2021-07-23 Jul 23, 2021
@cncf-ci cncf-ci force-pushed the autoaudit-prow branch 2 times, most recently from 3e8feaf to 05dc434 Compare July 23, 2021 04:10
@cncf-ci cncf-ci changed the title audit: update as of 2021-07-23 audit: update as of 2021-07-24 Jul 24, 2021
@cncf-ci cncf-ci force-pushed the autoaudit-prow branch 2 times, most recently from f8cddb7 to 26084b2 Compare July 24, 2021 13:10
@ameukam
Copy link
Member

ameukam commented Jul 26, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 26, 2021
@@ -1,22 +1,4 @@
[
{
"kind": "bigquery#dataset",
"id": "k8s-infra-ii-sandbox:etl_script_generated_set",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual suppression by @Riaankl : #1968 (comment)

@@ -26,54 +8,6 @@
},
"location": "US"
},
{
"kind": "bigquery#dataset",
"id": "k8s-infra-ii-sandbox:etl_staging",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual suppression by @Riaankl : #1968 (comment)

},
{
"kind": "bigquery#dataset",
"id": "k8s-infra-ii-sandbox:k8s_artifacts_dataset_bb_test",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

},
{
"kind": "bigquery#dataset",
"id": "k8s-infra-ii-sandbox:k8s_artifacts_gcslogs_appspot",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

},
{
"kind": "bigquery#dataset",
"id": "k8s-infra-ii-sandbox:kubernetes_public_logs",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

"labels": {
"group": "sig-contributor-experience"
},
"name": "projects/180382678033/secrets/k8s-triage-robot-github-token",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As expected by #2389

Comment on lines +4 to +7
"members": [
"group:[email protected]",
"group:[email protected]"
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As expected by #2389

{
"createTime": "2021-07-23T03:18:11.506633Z",
"etag": "\"15c7c1da789dc9\"",
"name": "projects/180382678033/secrets/k8s-triage-robot-github-token/versions/3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As expected by #2389. Only one version is used.

@@ -0,0 +1,7 @@
{
"createTime": "2021-07-21T22:43:41.525028Z",
"name": "projects/127754664067/secrets/k8s-infra-prow-hmac-token",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created by #2235.

{
"createTime": "2021-07-21T22:43:43.063748Z",
"etag": "\"15c7a9e708bec4\"",
"name": "projects/127754664067/secrets/k8s-infra-prow-hmac-token/versions/1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created by #2235.

@cncf-ci cncf-ci changed the title audit: update as of 2021-07-24 audit: update as of 2021-07-27 Jul 27, 2021
@cncf-ci cncf-ci force-pushed the autoaudit-prow branch 2 times, most recently from c2e922c to 3c122b9 Compare July 27, 2021 07:21
@cncf-ci cncf-ci changed the title audit: update as of 2021-07-27 audit: update as of 2021-07-28 Jul 28, 2021
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@@ -0,0 +1,70 @@
gs://k8s-release-asia/ :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was me claiming the bucket name by manually creating the bucket for #2396

@@ -0,0 +1,70 @@
gs://k8s-release-eu/ :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing, manually created for #2396

Comment on lines +4 to +8
"members": [
"serviceAccount:prow-deployer@k8s-infra-prow-build-trusted.iam.gserviceaccount.com"
],
"role": "organizations/758905017065/roles/container.deployer"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected from #2384

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cncf-ci, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit a4ac367 into kubernetes:main Jul 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/audit Audit of project resources, audit followup issues, code in audit/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants