Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release etcd 3.5.0-0 image #2236

Merged
merged 1 commit into from
Jun 19, 2021
Merged

Release etcd 3.5.0-0 image #2236

merged 1 commit into from
Jun 19, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jun 17, 2021

Part of kubernetes/kubernetes#102294

[root@daocloud ~]# docker pull gcr.io/k8s-staging-etcd/etcd:3.5.0-0
3.5.0-0: Pulling from k8s-staging-etcd/etcd
5dea5ec2316d: Already exists
f19a5990e757: Pull complete
ea2d08d27074: Pull complete
677a5c6b24cf: Pull complete
12201bf2f59f: Downloading [==========================>                        ]  5.111MB/9.669MB
12201bf2f59f: Pull complete
Digest: sha256:9ce33ba33d8e738a5b85ed50b5080ac746deceed4a7496c550927a7a19ca3b6d
Status: Downloaded newer image for gcr.io/k8s-staging-etcd/etcd:3.5.0-0
gcr.io/k8s-staging-etcd/etcd:3.5.0-0

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 17, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Jun 17, 2021

/hold
for kubernetes/release#2123
does this image build with the new kube-cross image? I need check

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2021
@serathius
Copy link
Contributor

/assign @justaugustus

@dims
Copy link
Member

dims commented Jun 17, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2021
@serathius
Copy link
Contributor

/milestone v1.22
ping @justaugustus

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 18, 2021
@dims
Copy link
Member

dims commented Jun 19, 2021

/assign @hasheddan @cpanato

@justaugustus
Copy link
Member

/hold
for kubernetes/release#2123
does this image build with the new kube-cross image? I need check

I'll be doing some verification on whether that is actually required (kubernetes/release#2124, #2248), but it doesn't need to block this PR.

/hold cancel
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, justaugustus, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9cf31fb into kubernetes:main Jun 19, 2021
@serathius
Copy link
Contributor

This was incorrect sha to be promoted. It promoted sha256:9ce33ba33d8e738a5b85ed50b5080ac746deceed4a7496c550927a7a19ca3b6d that was result of docker pull
image

Instead of sha256:9aeb407e6e534cdc82317a6f435b34e64d9c2bb60af945fae4f4204e47c4e6c8 that was under tag
image

Using docker pull is not correct way to get image hashes as docker will pull the image for local machine and not the multi arch manifest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants