Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

results of running audit script as of 2021-01-13 #1534

Merged
merged 39 commits into from
Feb 18, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
e8c3d1a
Fix audit script secret list typo
spiffxp Jan 13, 2021
c640149
Add TODOs for unhandled services
spiffxp Jan 13, 2021
0c2ca8c
audit: update org admin membership
spiffxp Jan 14, 2021
4083417
audit: add custom prow.viewer role to org
spiffxp Jan 14, 2021
c102166
audit: add k8s-infra-e2e-boskos-scale-* projects
spiffxp Jan 13, 2021
9fbc0f0
audit: add k8s-infra-e2e-boskos-gpu-* projects
spiffxp Jan 13, 2021
5caaf90
audit: add k8s-infra-e2e-boskos-[041-120] projects
spiffxp Jan 13, 2021
8add7de
audit: add k8s-infra-e2e-* manual projects
spiffxp Jan 14, 2021
ab02be3
audit: update existing k8s-infra-e2e-boskos-[001-040] projects
spiffxp Jan 13, 2021
b9b614e
audit: enable services for prow build clusters
spiffxp Jan 14, 2021
29426db
audit: add prow viewer role to manual k8s-infra-e2e projects
spiffxp Jan 14, 2021
af431d1
audit: add prow viewer/oncall groups to k8s-infra-prow-build-trusted
spiffxp Jan 14, 2021
e3d188c
audit: add k8s-infra-prow-build-trusted secrets
spiffxp Jan 14, 2021
6660eae
audit: add prow-deployer service account
spiffxp Jan 14, 2021
5b54a5c
audit: rm k8s-staging-release-test project
spiffxp Jan 13, 2021
7cd3c63
audit: rm k8s-sig-release-prototype project
spiffxp Jan 13, 2021
0612bab
audit: add k8s-staging-* projects
spiffxp Jan 14, 2021
1ff4c21
audit: k8s-staging-* service enables
spiffxp Jan 14, 2021
d64f009
audit: add k8s-conform buckets
spiffxp Jan 14, 2021
924a495
audit: allow k8s-infra-prow-build-trusted to manage gsuite groups
spiffxp Jan 14, 2021
e84f81f
audit: add k8s-gsuite/wg-k8s-infra-billing_pw secret
spiffxp Jan 14, 2021
df80579
audit: add k8s-release project
spiffxp Jan 14, 2021
ed6a857
audit: add kubernetes-public secrets
spiffxp Jan 14, 2021
a495042
audit: bind trusted prow to k8s-infra-gcr-promoter SAs
spiffxp Jan 14, 2021
daf7712
audit: misc project quota / service rename updates
spiffxp Jan 14, 2021
7df09ce
audit: add buckets to k8s-artifacts-prod
spiffxp Jan 14, 2021
de8ae62
audit: add k8s-artifacts-prod/k8s-infra-gcr-vuln-dashboard SA
spiffxp Jan 14, 2021
2c1fae7
audit: add k8s-artifacts-prod/k8s-infra-gcr-vuln-scanning SA
spiffxp Jan 14, 2021
9944317
audit: allow prow-build to write to k8s-release-test-prod bucket
spiffxp Jan 14, 2021
490c7c3
audit: add kubernetes-public/k8s-infra-monitoring-viewer SA
spiffxp Jan 14, 2021
c4c488d
audit: add kubernetes-public/k8s-infra-dns-updater SA
spiffxp Jan 14, 2021
7d31f1f
audit: add k8s.dev, kubernetes.dev DNS to kubernetes-public
spiffxp Jan 14, 2021
0146a9e
audit: FIX disable/delete k8s-staging-csi gke cluster
spiffxp Jan 14, 2021
cf5f5e3
audit: QQ k8s-staging-artifact-promoter: why is compute enabled
spiffxp Jan 14, 2021
d50b705
audit: QQ k8s-staging-capi-docker: why is dns enabled
spiffxp Jan 14, 2021
8b85662
audit: QQ k8s-staging-e2e-test-images: why are all these services ena…
spiffxp Jan 14, 2021
9841ab6
audit: QQ: k8s-gcr-backup-test-prod-bak: why bind this SA to prow-build?
spiffxp Jan 14, 2021
eb88737
audit: QQ kubernetes-public: why is an appengine SA present?
spiffxp Jan 14, 2021
d3ad9b7
audit: QQ kubernetes-public: why cloudfunctions and source enabled?
spiffxp Jan 14, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions audit/projects/k8s-staging-capi-docker/iam.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,24 @@
],
"role": "roles/cloudbuild.serviceAgent"
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on compute. I suspect the same, but I have less evidence). We should nuke it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added to #1675

"members": [
"serviceAccount:[email protected]"
],
"role": "roles/containeranalysis.ServiceAgent"
},
{
"members": [
"serviceAccount:k8s-infra-gcr-vuln-scanning@k8s-artifacts-prod.iam.gserviceaccount.com"
],
"role": "roles/containeranalysis.occurrences.viewer"
},
{
"members": [
"serviceAccount:service-44019431644@gcp-sa-containerscanning.iam.gserviceaccount.com"
],
"role": "roles/containerscanning.ServiceAgent"
},
{
"members": [
"serviceAccount:[email protected]"
Expand Down
54 changes: 54 additions & 0 deletions audit/projects/k8s-staging-capi-docker/services/dns/info.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
{
"id": "k8s-staging-capi-docker",
"kind": "dns#project",
"number": "44019431644",
"quota": {
"dnsKeysPerManagedZone": 4,
"gkeClustersPerPolicy": 100,
"kind": "dns#quota",
"managedZones": 10000,
"managedZonesPerNetwork": 10000,
"networksPerManagedZone": 100,
"networksPerPolicy": 100,
"policies": 100,
"resourceRecordsPerRrset": 100,
"rrsetAdditionsPerChange": 1000,
"rrsetDeletionsPerChange": 1000,
"rrsetsPerManagedZone": 10000,
"targetNameServersPerManagedZone": 50,
"targetNameServersPerPolicy": 50,
"totalRrdataSizePerChange": 100000,
"whitelistedKeySpecs": [
{
"algorithm": "ecdsap256sha256",
"kind": "dns#dnsKeySpec"
},
{
"algorithm": "ecdsap384sha384",
"kind": "dns#dnsKeySpec"
},
{
"algorithm": "rsasha256",
"keyLength": 2048,
"kind": "dns#dnsKeySpec"
},
{
"algorithm": "rsasha256",
"keyLength": 1024,
"keyType": "zoneSigning",
"kind": "dns#dnsKeySpec"
},
{
"algorithm": "rsasha512",
"keyLength": 2048,
"kind": "dns#dnsKeySpec"
},
{
"algorithm": "rsasha512",
"keyLength": 1024,
"keyType": "zoneSigning",
"kind": "dns#dnsKeySpec"
}
]
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[]
4 changes: 4 additions & 0 deletions audit/projects/k8s-staging-capi-docker/services/enabled.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
NAME TITLE
cloudbuild.googleapis.com Cloud Build API
cloudkms.googleapis.com Cloud Key Management Service (KMS) API
containeranalysis.googleapis.com Container Analysis API
containerregistry.googleapis.com Container Registry API
containerscanning.googleapis.com Container Scanning API
dns.googleapis.com Cloud DNS API
logging.googleapis.com Cloud Logging API
pubsub.googleapis.com Cloud Pub/Sub API
secretmanager.googleapis.com Secret Manager API
storage-api.googleapis.com Google Cloud Storage JSON API
storage-component.googleapis.com Cloud Storage