-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nginx] pass non-SNI TLS hello to default backend, Fixes #693 #696
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@donaldguy please sign the CLA |
Confirmed that this fixes the problem. Waiting on @donaldguy to sign CLA. Patch is needed for this to work correctly. |
Should be good now. I was waiting on cofounder of Tulip to sign CCLA |
/lgtm |
@donaldguy thanks! |
tested with image pushed to quay.io/donaldguy/nginx-ingress-controller:no-sni
Just verified that sites still load and that
openssl s_client
now worksw/ AND w/o a servername.
Fixes #693