Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nginx] pass non-SNI TLS hello to default backend, Fixes #693 #696

Merged
merged 1 commit into from
May 9, 2017
Merged

[nginx] pass non-SNI TLS hello to default backend, Fixes #693 #696

merged 1 commit into from
May 9, 2017

Conversation

donaldguy
Copy link

@donaldguy donaldguy commented May 8, 2017

tested with image pushed to quay.io/donaldguy/nginx-ingress-controller:no-sni

Just verified that sites still load and that openssl s_client now works
w/ AND w/o a servername.

Fixes #693

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 8, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 47.124% when pulling 2d1b6dc on donaldguy:nginx-no-sni into 4601775 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented May 9, 2017

@donaldguy please sign the CLA

@ghost
Copy link

ghost commented May 9, 2017

Confirmed that this fixes the problem. Waiting on @donaldguy to sign CLA. Patch is needed for this to work correctly.

@donaldguy
Copy link
Author

Should be good now. I was waiting on cofounder of Tulip to sign CCLA

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 9, 2017
@aledbf aledbf self-assigned this May 9, 2017
@aledbf
Copy link
Member

aledbf commented May 9, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2017
@aledbf
Copy link
Member

aledbf commented May 9, 2017

@donaldguy thanks!

@aledbf aledbf merged commit 433220d into kubernetes:master May 9, 2017
@ghost ghost mentioned this pull request May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants