-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update charts/* to keep project name display aligned #9931
Conversation
Hi @guessi. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thank you @guessi |
/kind documentation |
@strongjz @tao12345666333 @rikatz seeking review+approve for improvement in Docs |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guessi, longwuyuan, strongjz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
To keep project name display aligned across all documentations.
** To keep minimal risk of change, the PR will focus on
charts/*
files only.Types of changes
Which issue/s this PR fixes
Please refer to #9918, #9920 for more details.
How Has This Been Tested?
$ helm-docs --chart-search-root ./charts --values-file values.yaml INFO[2023-05-06T02:16:03+08:00] Found Chart directories [ingress-nginx] INFO[2023-05-06T02:16:03+08:00] Generating README Documentation for chart charts/ingress-nginx
$ git diff # showing no diff
Checklist:
Does my pull request need a release note?
No