-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update httpbin to httpbun #9919
Conversation
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @Spazzy757! |
Hi @Spazzy757. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9d985cf
to
a713b41
Compare
@Spazzy757 curious why the LANG and LC vars need to be removed from Dockerfile |
@longwuyuan honestly haven't finished it yet, just getting it working first then will clean it all up 😅 |
8f1426b
to
ba5ab71
Compare
assert.Nil(ginkgo.GinkgoT(), err) | ||
|
||
httpbinIP = e.Subsets[0].Addresses[0].IP | ||
httpbunIP = e.Subsets[0].Addresses[0].IP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follow up for another PR: this repeats a lot. Maybe we should define httpBun as a real part of framework, and add this as a method or part of the "f" structure
Spec: corev1.ServiceSpec{ | ||
Ports: []corev1.ServicePort{ | ||
{ | ||
Name: "http", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cant remember, so asking: do we have TLS tests pointing to httpbin or echo? do we want to move those to httpbun as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the backend matter?
If we can get rid of an image and move everything echo does to httpbun, I'm all for it. Another follow-up issue.
5e3d814
to
e8d9bee
Compare
Signed-off-by: Spazzy <[email protected]>
/approve This is a very welcome migration. Just make sure we are using that internal httpbun image as much as possible here, and we are good to go. /hold |
/lgtm Thanks for this @Spazzy757. This is a huge improvement to our e2e framework, removing unsupported images like httpbin. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, Spazzy757, strongjz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Spazzy757 , like this a lot. Looking forward to the framework PR |
What this PR does / why we need it:
This PR is moving from HTTPBin to HTTPBun in order to fix flaky E2E tests.
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist:
Does my pull request need a release note?
Any user-visible or operator-visible change qualifies for a release note. This could be a:
No release notes are required for changes to the following:
For more tips on writing good release notes, check out the Release Notes Handbook