Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s versions #9879

Merged
merged 8 commits into from
Apr 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 7 additions & 21 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ jobs:
with:
name: docker.tar.gz
path: docker.tar.gz

retention-days: 5
helm:
name: Helm chart
runs-on: ubuntu-latest
Expand All @@ -205,7 +205,7 @@ jobs:

strategy:
matrix:
k8s: [v1.24.7, v1.25.3, v1.26.0]
k8s: [v1.24.12, v1.25.8, v1.26.3]

steps:
- name: Checkout
Expand Down Expand Up @@ -255,11 +255,6 @@ jobs:
run: |
kind create cluster --image=kindest/node:${{ matrix.k8s }}

- uses: geekyeggo/delete-artifact@54ab544f12cdb7b71613a16a2b5a37a9ade990af # v2.0.0
with:
name: docker.tar.gz
failOnError: false

- name: Load images from cache
run: |
echo "loading docker images..."
Expand All @@ -285,7 +280,7 @@ jobs:

strategy:
matrix:
k8s: [v1.24.7, v1.25.3, v1.26.0]
k8s: [v1.24.12, v1.25.8, v1.26.3]

steps:
- name: Checkout
Expand All @@ -301,11 +296,6 @@ jobs:
run: |
kind create cluster --image=kindest/node:${{ matrix.k8s }} --config test/e2e/kind.yaml

- uses: geekyeggo/delete-artifact@54ab544f12cdb7b71613a16a2b5a37a9ade990af # v2.0.0
with:
name: docker.tar.gz
failOnError: false

- name: Load images from cache
run: |
echo "loading docker images..."
Expand All @@ -327,6 +317,7 @@ jobs:
name: e2e-test-reports-${{ matrix.k8s }}
path: 'test/junitreports/report*.xml'


kubernetes-chroot:
name: Kubernetes chroot
runs-on: ubuntu-latest
Expand All @@ -338,7 +329,7 @@ jobs:

strategy:
matrix:
k8s: [v1.24.7, v1.25.3, v1.26.0]
k8s: [v1.24.12, v1.25.8, v1.26.3]

steps:

Expand All @@ -355,11 +346,6 @@ jobs:
run: |
kind create cluster --image=kindest/node:${{ matrix.k8s }} --config test/e2e/kind.yaml

- uses: geekyeggo/delete-artifact@54ab544f12cdb7b71613a16a2b5a37a9ade990af # v2.0.0
with:
name: docker.tar.gz
failOnError: false

- name: Load images from cache
run: |
echo "loading docker images..."
Expand All @@ -375,7 +361,7 @@ jobs:
kind get kubeconfig > $HOME/.kube/kind-config-kind
make kind-e2e-test

- name: Uplaod e2e junit-reports
- name: Upload e2e junit-reports
uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # v3.1.2
if: success() || failure()
with:
Expand Down Expand Up @@ -461,7 +447,7 @@ jobs:

strategy:
matrix:
k8s: [v1.24.7, v1.25.3, v1.26.0]
k8s: [v1.24.12, v1.25.8, v1.26.3]

steps:
- name: Checkout
Expand Down
9 changes: 6 additions & 3 deletions OWNERS_ALIASES
Original file line number Diff line number Diff line change
Expand Up @@ -14,24 +14,27 @@ aliases:
- ElvinEfendi
- rikatz
- strongjz
- cpanato
- puerco
- tao12345666333

ingress-nginx-reviewers:
- ElvinEfendi
- rikatz
- strongjz
- puerco
- cpanato
- tao12345666333

ingress-nginx-helm-maintainers:
- ChiefAlexander
- cpanato
- strongjz

ingress-nginx-helm-reviewers:
- ChiefAlexander
- cpanato
- strongjz

ingress-nginx-docs-maintainers:
- IamNoah1
- longwuyuan
- tao12345666333

Expand Down
2 changes: 1 addition & 1 deletion build/dev-env.sh
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ echo "[dev-env] building image"
make build image
docker tag "${REGISTRY}/controller:${TAG}" "${DEV_IMAGE}"

export K8S_VERSION=${K8S_VERSION:-v1.25.2@sha256:9be91e9e9cdf116809841fc77ebdb8845443c4c72fe5218f3ae9eb57fdb4bace}
export K8S_VERSION=${K8S_VERSION:-v1.26.3@sha256:61b92f38dff6ccc29969e7aa154d34e38b89443af1a2c14e6cfbd2df6419c66f}

KIND_CLUSTER_NAME="ingress-nginx-dev"

Expand Down
2 changes: 1 addition & 1 deletion charts/ingress-nginx/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ Previous versions of this chart had a `controller.stats.*` configuration block,

### ExternalDNS Service Configuration

Add an [ExternalDNS](https://github.com/kubernetes-incubator/external-dns) annotation to the LoadBalancer service:
Add an [ExternalDNS](https://github.com/kubernetes-sigs/external-dns) annotation to the LoadBalancer service:

```yaml
controller:
Expand Down
2 changes: 1 addition & 1 deletion charts/ingress-nginx/README.md.gotmpl
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ Previous versions of this chart had a `controller.stats.*` configuration block,

### ExternalDNS Service Configuration

Add an [ExternalDNS](https://github.com/kubernetes-incubator/external-dns) annotation to the LoadBalancer service:
Add an [ExternalDNS](https://github.com/kubernetes-sigs/external-dns) annotation to the LoadBalancer service:

```yaml
controller:
Expand Down
13 changes: 10 additions & 3 deletions test/e2e/run-chart-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export KUBECONFIG="${KUBECONFIG:-$HOME/.kube/kind-config-$KIND_CLUSTER_NAME}"
if [ "${SKIP_CLUSTER_CREATION:-false}" = "false" ]; then
echo "[dev-env] creating Kubernetes cluster with kind"

export K8S_VERSION=${K8S_VERSION:-v1.21.1@sha256:69860bda5563ac81e3c0057d654b5253219618a22ec3a346306239bba8cfa1a6}
export K8S_VERSION=${K8S_VERSION:-v1.26.3@sha256:61b92f38dff6ccc29969e7aa154d34e38b89443af1a2c14e6cfbd2df6419c66f}

kind create cluster \
--verbosity=${KIND_LOG_LEVEL} \
Expand Down Expand Up @@ -91,9 +91,16 @@ echo "[dev-env] copying docker images to cluster..."
kind load docker-image --name="${KIND_CLUSTER_NAME}" --nodes=${KIND_WORKERS} ${REGISTRY}/controller:${TAG}

if [ "${SKIP_CERT_MANAGER_CREATION:-false}" = "false" ]; then
curl -fsSL -o cmctl.tar.gz https://github.com/cert-manager/cert-manager/releases/download/v1.11.1/cmctl-linux-amd64.tar.gz
tar xzf cmctl.tar.gz
chmod +x cmctl
./cmctl help
echo "[dev-env] apply cert-manager ..."
kubectl apply --wait -f https://github.com/cert-manager/cert-manager/releases/download/v1.10.0/cert-manager.yaml
sleep 10
kubectl apply --wait -f https://github.com/cert-manager/cert-manager/releases/download/v1.11.0/cert-manager.yaml
kubectl wait --timeout=30s --for=condition=available deployment/cert-manager -n cert-manager
kubectl get validatingwebhookconfigurations cert-manager-webhook -ojson | jq '.webhooks[].clientConfig'
kubectl get endpoints -n cert-manager cert-manager-webhook
./cmctl check api --wait=2m
fi

echo "[dev-env] running helm chart e2e tests..."
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/run-kind-e2e.sh
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ echo "Running e2e with nginx base image ${NGINX_BASE_IMAGE}"
if [ "${SKIP_CLUSTER_CREATION}" = "false" ]; then
echo "[dev-env] creating Kubernetes cluster with kind"

export K8S_VERSION=${K8S_VERSION:-v1.25.2@sha256:9be91e9e9cdf116809841fc77ebdb8845443c4c72fe5218f3ae9eb57fdb4bace}
export K8S_VERSION=${K8S_VERSION:-v1.26.3@sha256:61b92f38dff6ccc29969e7aa154d34e38b89443af1a2c14e6cfbd2df6419c66f}

# delete the cluster if it exists
if kind get clusters | grep "${KIND_CLUSTER_NAME}"; then
Expand Down