Remove _ssl_expire_time_seconds metric by identifier

[Lyt99]

What this PR does / why we need it:

This PR added a new label identifier for _ssl_expire_time_seconds metric, which has the same meaning as the label in _ssl_certificate_info.
When your TLS configuration changed, it will try to remove _ssl_expire_time_seconds by identifier, instead of host.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Follow the instructions in #9705.

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.
• Added Release Notes.

Does my pull request need a release note?

Any user-visible or operator-visible change qualifies for a release note. This could be a:

• CLI change
• API change
• UI change
• configuration schema change
• behavioral change
• change in non-functional attributes such as efficiency or availability, availability of a new platform
• a warning about a deprecation
• fix of a previous Known Issue
• fix of a vulnerability (CVE)

No release notes are required for changes to the following:

• Tests
• Build infrastructure
• Fixes for unreleased bugs

For more tips on writing good release notes, check out the Release Notes Handbook

PLACE RELEASE NOTES HERE

[k8s-ci-robot]

Hi @Lyt99. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[longwuyuan]

I am not a developer so I can't comment on the code but I did test this and I discovered that at least on a grafana dashboard, with a query like

avg(nginx_ingress_controller_ssl_expire_time_seconds{kubernetes_pod_name=~"$controller",namespace=~"$namespace",ingress=~"$ingress"}) by (host) - time()

I can see still the hostname of the ingress, where I have deleted the TLS section (and also deleted the secret from the namespace).

/triage accepted
/kind bug
/priority important-longterm

But there are many many nuances to this like I will seek to check ;

• that this "seconds" is a prometheus metric of type guage
• that this metric is not being deleted very quickly after deleting the TLS section in the ingress, but may get deleted later
• that a "average" is being checked in this query and that is a valid query
• other such validations

I hope this PR is not going to introduce a new problem because there is no extensive test-data here for all the real-world scenes

[tao12345666333]

I will run test first

/ok-to-test

[tao12345666333]

I will run test first

/ok-to-test

[longwuyuan]

I am not certain if CI has a test for this.
I just want to comment that raw query in prometheus has a metric like this which returns all certs ever used, even the deleted ones

From above list the last 2 are deleted already

[longwuyuan]

And I m also unsure if the change proposed will not cause any new problems

[github-actions]

This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach #ingress-nginx-dev on Kubernetes Slack.

[k8s-triage-robot]

The lifecycle/frozen label can not be applied to PRs.

This bot removes lifecycle/frozen from PRs because:

• Commenting /lifecycle frozen on a PR has not worked since March 2021
• PRs that remain open for >150 days are unlikely to be easily rebased

You can:

• Rebase this PR and attempt to get it merged
• Close this PR with /close

Please send feedback to sig-contributor-experience at kubernetes/community.

/remove-lifecycle frozen

[tao12345666333]

/assign

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	140ba3182d89016ba8a5639f1c7941209f99ec1c
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/64f147cd7e574a00082ad670

[ndlanier]

Is there any update on this?

[tao12345666333]

There is only this one small nit.
We can solve the problems we have encountered with other parts.
Please update the comments and pull the code from the main branch for rebase.
Then we can move forward. Thank you!

[tao12345666333]

/retest

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	00d32b2
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/660a1d56d13d790008ef9371

[Lyt99]

@tao12345666333 Hi, I've updated the comment and rebase the main branch.

Thank you!

[tao12345666333]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Lyt99, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tao12345666333]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tao12345666333]

/cherry-pick release-1.10

[k8s-infra-cherrypick-robot]

@tao12345666333: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@tao12345666333: new pull request created: #11236

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Gacko]

It seems CI on main and release-1.10 is more up-to-date than the source branch and therefore fails in the cherry-pick.

[Gacko]

https://github.com/kubernetes/ingress-nginx/actions/runs/8605616383/job/23582254336?pr=11236

But can't tell the reason, at least this wasn't changed in your PR.

[Lyt99]

But can't tell the reason, at least this wasn't changed in your PR.

#11228 made an upgrade for google.golang.org/grpc to v1.63.0, which seemed to introduce the deprecation of Dial().

But gprc v1.63.1 removed the deprecation tag . Upgrading to this version should solve the lint problem.

[Gacko]

... damn, you're good! Thanks for the quick investigation! Do you want to file a PR for bumping it? That would be nice. Just tag me, I'll lgtm it then.

[Gacko]

/cherry-pick release-1.10

[k8s-infra-cherrypick-robot]

@Gacko: new pull request created: #11239

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.