update kube-webhook-certgen to v1.5.1

[arikgrahl]

What this PR does / why we need it:

• update kube-webhook-certgen to v1.5.1

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

–

How Has This Been Tested?

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.
• Added Release Notes.

Does my pull request need a release note?

Update [kube-webhook-certgen](https://github.com/jet/kube-webhook-certgen) to [v1.5.1](https://github.com/jet/kube-webhook-certgen/releases/tag/v1.5.1)

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: arikgrahl / name: Arik Grahl (0c5151c)

[k8s-ci-robot]

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @arikgrahl!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @arikgrahl. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rikatz]

We have our own fork of kube web certgen. Please check images/ folder

[arikgrahl]

Thanks for pointing out the fork.
The README.md in the images folder says

Only the nginx image is meant to be published
Other images are used as examples for a feature of the ingress controller or to run e2e tests

In the latest version of the ingress-nginx helm chart, the image registry.k8s.io/ingress-nginx/kube-webhook-certgen:v20220916-gd32f8c343@sha256:39c5b2e3310dc4264d638ad28d9d1d96c4cbb2b2dcfb52368fe4e3c63f61e10f is used.
Does this image result from the said fork?

The endpoint https://registry.k8s.io/v2/ingress-nginx/kube-webhook-certgen/tags/list lists the newer tag v20221220-controller-v1.5.1-58-g787ea74b6 among other, to which this PR updates the helm chart.
Regardless of this, for better transparency, an image tag with an actual application version number would be favored, which the image tag of this update would satisfy.

[strongjz]

@arikgrahl Please rebase your PR and sign the CLA.

thank you for your work on this. Tracking and keeping all of our images up to date is not an easy task so we appreciate this work.

-James

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arikgrahl
Once this PR has been reviewed and has the lgtm label, please ask for approval from strongjz. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[arikgrahl]

I have rebased my PR. In that course I also fixed the email address in the commit so that the CLA check for the previously signed CLA passed as well. Thank you for pointing this out!

[tao12345666333]

/ok-to-test
/hold

There may be a reason for this image not being updated. I will think about the reason

[arikgrahl]

@tao12345666333, any updates on this?

To me it is unclear which exact upstream version is behind the tag v20220916-gd32f8c343.
This makes it personally hard to predict which changes are introduced by this update to the tag v20221220-controller-v1.5.1-58-g787ea74b6.
At least the updated tag has some potential link to an appropriate upstream version (v1.5.1), which could clear up any uncertainties in this regard for future updates.

This being said, the decision of accepting this PR will not be easier in the future without further background information about the image tags mentioned above.
Possibly the test suite is sufficient to identify any breaking changes for this update?
Otherwise, I will be happy to volunteer for specific testing on this update.

Thank you in advance!

[strongjz]

I'm working on a 1.6.5 release this week, and I just upgraded all the images to golang 1.20 and alpine 3.17.2

https://github.com/kubernetes/ingress-nginx/pull/9690/files#diff-a4e1312dfd8eddfe3111f1c850a112c92040b42c8214d434cc1bdd44aa4c23e3

kubernetes/k8s.io#4929

So there be an even newer version of the cert image.

We can close this issue in anticipation of the new release.

Thank you,
James

/close

[k8s-ci-robot]

@strongjz: Closed this PR.

In response to this:

I'm working on a 1.6.5 release this week, and I just upgraded all the images to golang 1.20 and alpine 3.17.2

https://github.com/kubernetes/ingress-nginx/pull/9690/files#diff-a4e1312dfd8eddfe3111f1c850a112c92040b42c8214d434cc1bdd44aa4c23e3

kubernetes/k8s.io#4929

So there be an even newer version of the cert image.

We can close this issue in anticipation of the new release.

Thank you,
James

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[arikgrahl]

@strongjz, thank you for this upcoming release, i am looking forward to it!

However, the upcoming release will update components in the images folder, among others.
As already pointed out, the README.md in this folder states:

Only the nginx image is meant to be published
Other images are used as examples for a feature of the ingress controller or to run e2e tests

If I am not missing something, this means that the helm chart, for which this PR is aiming, will remain with the old version.
I guess this was already initially confused by @rikatz.

Please reconsider including this minor update if I am not wrong.

Thank you again for your work!

[longwuyuan]

@arikgrahl when a new kube-webhook-certen image is built by cloudbuild, it will be promoted to be published from the prod registry and the manifests that refer to the kube-webhook-certgen image will get a update on the tag and the digest.

[arikgrahl]

@longwuyuan, thank you for clarifying.
I thought that the process would be like this, but noticed a few other tags, which seemed newer than the one in the helm chart manifests.

curl -s -L https://registry.k8s.io/v2/ingress-nginx/kube-webhook-certgen/tags/list | jq .tags

[
  "sha256-2188def723c8fcb2635fbe54607ac3b4efba581c4fcc3d2279ec9c57da1b2f6f.sig",
  "sha256-39c5b2e3310dc4264d638ad28d9d1d96c4cbb2b2dcfb52368fe4e3c63f61e10f.sig",
  "sha256-4d99688e557396f5baa150e019ff7d5b7334f9b9f9a8dab64038c5c2a006f6b5.sig",
  "sha256-549e71a6ca248c5abd51cdb73dbc3083df62cf92ed5e6147c780e30f7e007a47.sig",
  "sha256-ccdb2382b53ed42fd76bfbff90a5b8a5815af0b3b8c6dfb9118a34770d9cac11.sig",
  "v1.0",
  "v1.1",
  "v1.1.1",
  "v1.2.0",
  "v1.3.0",
  "v20220916-gd32f8c343",
  "v20221219-controller-v1.5.1-49-ge3e0d9c1f",
  "v20221220-controller-v1.5.1-58-g787ea74b6"
]

Still it remains unclear, where the actual images come from and which exact (upstream) version is behind the respective image tags.
If the components from the image folder are utilized in the helm chart manifests, the respective notice should reflect this.
In any case, I am happy to enhance the documentation to create as much transparency as possible in this great open source project.

[longwuyuan]

The explaining is long and complicated. For practical ends, be assured that regardless of tags you see, a documented & recommended will always get you the kube-webhook-certgen code bits that you need.

There used to be a upstream. Now there is no upstream. We painfully forked and also carefully maintain the fork. Docs and users are user-facing but kube-webook-certgen is the woodworks, hence not much is needed except for it to work as expected.

Latest is as James said. He will trigger build of a new kube-webhook-certgen and code will be updated to the new tag and digest.

[arikgrahl]

@longwuyuan, thank you so much for shedding light on this and patiently answering my questions!

Thank you for the great work in this project, I appreciate it very much.

[longwuyuan]

@longwuyuan, thank you so much for shedding light on this and patiently answering my questions!

Thank you for the great work in this project, I appreciate it very much.

🙏 community