Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to pass a target test #9542

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Allow to pass a target test #9542

merged 1 commit into from
Feb 8, 2023

Conversation

kirs
Copy link
Contributor

@kirs kirs commented Jan 24, 2023

This PR makes the feedback loop faster, allowing to run test/test-lua.sh rootfs/etc/nginx/lua/test/your_test.lua without having to wait for the full test suite.

@ElvinEfendi
cc @plantfansam

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 24, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 24, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @kirs. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 24, 2023
kirs
kirs commented Jan 24, 2023
View reviewed changes
test/test-lua.sh
"./rootfs/etc/nginx/lua/test/run.lua"
)

if [ $# -eq 0 ]; then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun fact: I always struggle with bash so chatgpt wrote this for me:

Screenshot 2023-01-24 at 11 35 45 AM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As well as the array logic:

Screenshot 2023-01-24 at 11 36 22 AM

@rikatz
Copy link
Contributor

rikatz commented Jan 26, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 26, 2023
plantfansam
plantfansam approved these changes Jan 30, 2023
View reviewed changes
Copy link

@plantfansam plantfansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me! I had a couple questions but no blockers.

test/test-lua.sh Show resolved Hide resolved
test/test-lua.sh Show resolved Hide resolved
@kirs
Copy link
Contributor Author

kirs commented Feb 2, 2023

@tao12345666333 👋 would appreciate your look at this tiny PR. Thanks!

@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2023
@ElvinEfendi
Copy link
Member

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElvinEfendi, kirs, plantfansam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6f713b7 into kubernetes:main Feb 8, 2023
strongjz added a commit that referenced this pull request Feb 9, 2023
@strongjz
Revert "Allow to pass a target test (#9542)"
ad18e3f 
This reverts commit 6f713b7.
@strongjz
Copy link
Member

strongjz commented Feb 9, 2023

This looks to be blocking issues with reverting the path type problems we had, and GitHub revert only reverts the codes, not the parent differences that #9585 made

@kirs i think we need you to rebase on main, after I get 9585 back into history, this merge reintroduced what 9585 removed.

I have also pushed this branch to my fork https://github.com/strongjz/ingress-nginx/tree/run-test-target

I can create a patch and push it if you do not want to hassle with the rebase.

I apologize for the issues this has caused.

@ElvinEfendi ElvinEfendi mentioned this pull request Feb 9, 2023
Merged
strongjz pushed a commit to strongjz/ingress-nginx that referenced this pull request Feb 10, 2023
@kirs
Allow to pass a target test (kubernetes#9542)
d5384b2
k8s-ci-robot pushed a commit that referenced this pull request Feb 10, 2023
@strongjz @jongwooo
@kirs @schaefec
update history and allow to pass a target test (#9605)
59d247d 
* Replace deprecated command with environment file (#9581)

Signed-off-by: jongwooo <[email protected]>

* Allow to pass a target test (#9542)

* start 1.6.0 release

Signed-off-by: James Strong <[email protected]>

* testing auto change

Signed-off-by: James Strong <[email protected]>

* Add mage files for changelog

Signed-off-by: James Strong <[email protected]>

* change format

Signed-off-by: James Strong <[email protected]>

* fixed boiler plate lint

Signed-off-by: James Strong <[email protected]>

* Align default value for keepalive_request with NGINX default (#9518)

* Align default value for keepalive_request with NGINX default

---------

Signed-off-by: jongwooo <[email protected]>
Signed-off-by: James Strong <[email protected]>
Co-authored-by: Jongwoo Han <[email protected]>
Co-authored-by: Kir Shatrov <[email protected]>
Co-authored-by: Christian Schaefer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plantfansam plantfansam plantfansam approved these changes

@rikatz rikatz Awaiting requested review from rikatz

@tao12345666333 tao12345666333 Awaiting requested review from tao12345666333

Assignees

@ElvinEfendi ElvinEfendi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kirs @k8s-ci-robot @rikatz @ElvinEfendi @strongjz @plantfansam