-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(grafana-dashboard): remove hardcoded namespace references #9523
Conversation
@aslafy-z: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @aslafy-z. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aslafy-z, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…e (was deleted entirely in kubernetes#9523)
Actually, I don't think one wants to entirely remove the Ingress namespace selector, as you did here. I think one would want to make it a variable, and use it in other panels as well. That is what #9092 does. |
…rd (#9092) * grafana/dashboards/nginx.json: re-add exported_namespace as a variable (was deleted entirely in #9523) * dashboards/nginx.json: switch around ingress and namespace selectors, and rename "Exported Namespace" to "Ingress Namespace" authored by tghartland at https://gist.github.com/tghartland/9147d88f991a95d4bab0fa7278c237eb * dashboards/nginx.json: make "Ingress Request Volume" and "Ingress Success Rate" panels look at selected Ingress Namespaces only, and rename two panel titels to use the renamed variable as suggested by tghartland in #9092 (comment) * dashboards/nginx.json: apply Ingress Namespace selection to "Ingress Percentile Response Times and Transfer Rates" as well this is from #9092 (comment) also by tghartland
What this PR does / why we need it:
Remove
uat
hardcoded reference in some panels of the grafana dashboard.Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Remove the
exported_namespace="uat"
to the panels.Check the panels are shown correctly.
Checklist:
Does my pull request need a release note?
Any user-visible or operator-visible change qualifies for a release note. This could be a:
No release notes are required for changes to the following:
For more tips on writing good release notes, check out the Release Notes Handbook