Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback 1.5.2 #9469

Merged
merged 3 commits into from
Dec 30, 2022
Merged

Rollback 1.5.2 #9469

merged 3 commits into from
Dec 30, 2022

Conversation

strongjz
Copy link
Member

Signed-off-by: James Strong [email protected]

Reverting 1.5.2, there are breaking changes to path type that are causing issues.

#9464
#9466

James Strong added 2 commits December 29, 2022 19:56
Signed-off-by: James Strong <[email protected]>
Signed-off-by: James Strong <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 30, 2022
@k8s-ci-robot
Copy link
Contributor

@strongjz: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority area/docs area/helm Issues or PRs related to helm charts labels Dec 30, 2022
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 30, 2022
Signed-off-by: James Strong <[email protected]>
@strongjz strongjz requested review from rikatz and removed request for ChiefAlexander December 30, 2022 01:04
@rikatz
Copy link
Contributor

rikatz commented Dec 30, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@strongjz strongjz merged commit 2ea0109 into kubernetes:main Dec 30, 2022
@strongjz strongjz deleted the rollback-1.5.2 branch December 30, 2022 02:11
@Callek
Copy link
Contributor

Callek commented Dec 30, 2022

Either artifacthub is confused OR this never actually rolled back.

https://artifacthub.io/packages/helm/ingress-nginx/ingress-nginx/4.4.2?modal=template&compare-to=4.4.1

The CHANGELOG on artifacthub is also identical to the changelog for 4.4.0.

CCL @strongjz

@strongjz
Copy link
Member Author

Either artifacthub is confused OR this never actually rolled back.

https://artifacthub.io/packages/helm/ingress-nginx/ingress-nginx/4.4.2?modal=template&compare-to=4.4.1

The CHANGELOG on artifacthub is also identical to the changelog for 4.4.0.

CCL @strongjz

I reverted commits and didn't update the change log. The issue now is that with artifacthub We'd have to release a new chart to update the changelog. So effectively 4.4.0 and 4.4.2 are the same. Apologize for the confusion, we wanted to rollout a fix and I was only thinking of rolling back the controller version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants