Add missing control char on regex validation

[rikatz]

What this PR does / why we need it:

I forgot to add the "optional" (?) control char on regex validation, and enable the regex path when rewrite annotation is being used

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

Fixes #9464

How Has This Been Tested?

Unit test based on user report

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.
• Added Release Notes.

Does my pull request need a release note?

Any user-visible or operator-visible change qualifies for a release note. This could be a:

• CLI change
• API change
• UI change
• configuration schema change
• behavioral change
• change in non-functional attributes such as efficiency or availability, availability of a new platform
• a warning about a deprecation
• fix of a previous Known Issue
• fix of a vulnerability (CVE)

No release notes are required for changes to the following:

• Tests
• Build infrastructure
• Fixes for unreleased bugs

For more tips on writing good release notes, check out the Release Notes Handbook

Fix regex validation on path

[k8s-ci-robot]

@rikatz: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[longwuyuan]

/retest

[justinmchase]

The latest version of nginx-ingress appears to be suddenly returning errors and failing for all of my paths. Here is an example:

rules:
- http:
    paths:
    - pathType: Prefix
      path: /example(/|$)(.*)

I'd just like to make sure that the changes you're putting in place account for this path, which doesn't include ? but is still broken.

[longwuyuan]

Fixed release will be out in few days.

…

On Fri, 13 Jan, 2023, 7:49 pm Justin Chase, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In internal/ingress/controller/controller_test.go <#9465 (comment)> : > + t.Run("When invalid path is passed to Ingress", func(t *testing.T) { + nginx.store = fakeIngressStore{ + ingresses: []*ingress.Ingress{}, + } + nginx.command = testNginxTestCommand{ + t: t, + err: nil, + } + ing.Spec.Rules[0].HTTP.Paths = append(ing.Spec.Rules[0].HTTP.Paths, networking.HTTPIngressPath{ + Path: "/foo/bar/;xpto", + }) + if err := nginx.CheckIngress(ing); err == nil { + t.Errorf("with an invalid path, ingress should be rejected") + } + }) + Can we add a test such as: t.Run("When invalid path is passed to Ingress", func(t *testing.T) { nginx.store = fakeIngressStore{ ingresses: []*ingress.Ingress{}, } nginx.command = testNginxTestCommand{ t: t, err: nil, } ing.Spec.Rules[0].HTTP.Paths = append(ing.Spec.Rules[0].HTTP.Paths, networking.HTTPIngressPath{ Path: "/example(/|$)(.*)", }) if err := nginx.CheckIngress(ing); err != nil { t.Errorf("ingress should not be rejecting valid paths") } }) — Reply to this email directly, view it on GitHub <#9465 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGZVWVK75WYRVPIN6SV35LWSFP57ANCNFSM6AAAAAATMPTZMA> . You are receiving this because you commented.Message ID: ***@***.***>

[rikatz]

/close
#9511 is taking care of this

[k8s-ci-robot]

@rikatz: Closed this PR.

In response to this:

/close
#9511 is taking care of this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.