Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hpa): deprecated api version, bump to v2 #9348

Merged
merged 8 commits into from
Dec 4, 2022
Merged

fix(hpa): deprecated api version, bump to v2 #9348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c8b3c2c
fix(hpa): deprecated api version, bump to v2
sjoukedv Nov 29, 2022
a6cb837
chore(hpa): abstract hpa apiVersion to helm value
sjoukedv Nov 29, 2022
f9a4ced
feat(hpa): add controller.autoscaling.apiVersion docs in README
sjoukedv Nov 29, 2022
0e120d3
docs(hpa): quotes around apiVersion string type
sjoukedv Nov 29, 2022
5e7905e
chore(hpa): run helm-docs in repo
sjoukedv Nov 29, 2022
bf9fefc
chore(hpa): remove local helm-docs module install and output
sjoukedv Nov 29, 2022
19d1ae5
docs(helm): add hpa controller.autoscaling.apiVersion description
sjoukedv Nov 30, 2022
2568954
docs(hpa): remove autoscaling.apiVersion description as it fails ci
sjoukedv Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/ingress-nginx/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ Kubernetes: `>=1.20.0-0`
| controller.affinity | object | `{}` | Affinity and anti-affinity rules for server scheduling to nodes # Ref: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#affinity-and-anti-affinity # |
| controller.allowSnippetAnnotations | bool | `true` | This configuration defines if Ingress Controller should allow users to set their own *-snippet annotations, otherwise this is forbidden / dropped when users add those annotations. Global snippets in ConfigMap are still respected |
| controller.annotations | object | `{}` | Annotations to be added to the controller Deployment or DaemonSet # |
| controller.autoscaling.apiVersion | string | `"autoscaling/v2"` | |
| controller.autoscaling.behavior | object | `{}` | |
| controller.autoscaling.enabled | bool | `false` | |
| controller.autoscaling.maxReplicas | int | `11` | |
Expand Down
2 changes: 1 addition & 1 deletion charts/ingress-nginx/templates/controller-hpa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{{- if and .Values.controller.autoscaling.enabled (or (eq .Values.controller.kind "Deployment") (eq .Values.controller.kind "Both")) -}}
{{- if not .Values.controller.keda.enabled }}

apiVersion: autoscaling/v2beta2
apiVersion: {{ .Values.controller.autoscaling.apiVersion }}
kind: HorizontalPodAutoscaler
metadata:
annotations:
Expand Down
1 change: 1 addition & 0 deletions charts/ingress-nginx/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,7 @@ controller:

# Mutually exclusive with keda autoscaling
autoscaling:
apiVersion: autoscaling/v2
enabled: false
minReplicas: 1
maxReplicas: 11
Expand Down