Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of nginx configuration deserialization #92

Merged
merged 1 commit into from
Jan 2, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Dec 28, 2016

No description provided.

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 28, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 40.575% when pulling 76387d065887bc8b2e39f9025a36d4fbbd19afb9 on aledbf:custom-timeouts into 8e90fc0 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 40.597% when pulling 77698b254f624ad8bb23423020cbef683a934732 on aledbf:custom-timeouts into 8e90fc0 on kubernetes:master.

@bprashanth
Copy link
Contributor

LGTM but you have a conflict

@bprashanth
Copy link
Contributor

Feel free to merge once it's resolved

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 40.655% when pulling c0b5be6 on aledbf:custom-timeouts into 5cdb8fe on kubernetes:master.

@aledbf aledbf merged commit 6af7684 into kubernetes:master Jan 2, 2017
@aledbf aledbf deleted the custom-timeouts branch January 13, 2017 11:43
hnrytrn added a commit to hnrytrn/ingress-nginx that referenced this pull request Aug 9, 2018
haoqing0110 pushed a commit to stolostron/management-ingress that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. nginx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants