-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add:(admission-webhooks) ability to set securityContext #9186
add:(admission-webhooks) ability to set securityContext #9186
Conversation
…iners createSecret and patchWebhook Signed-off-by: ybelMekk <[email protected]>
Hi @ybelMekk. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@longwuyuan, fixed the PR, you have time for a review? 😅 |
Please update the release notes at the bottom of the PR description. /kind feature |
Fixing! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: strongjz, ybelMekk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…iners createSecret and patchWebhook (kubernetes#9186) Signed-off-by: ybelMekk <[email protected]> Signed-off-by: ybelMekk <[email protected]>
helm version: 3.9.2
ingress-nginx version: ingress-nginx-4.2.3.tgz
What this PR does / why we need it:
Stumbled in to this when working with kyverno and enforced strict policies.
Kyverno and using strict policy configuration, job create for
ingress-nginx-admission-create
fails with policiesrequire-drop-all
. Adding the ability to configure containers in webhooks create and patch from helm values.NONE
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist:
Does my pull request need a release note?
Any user-visible or operator-visible change qualifies for a release note. This could be a:
No release notes are required for changes to the following:
For more tips on writing good release notes, check out the Release Notes Handbook